1325199 - gfxDWriteFont::GetGlyphRenderingOptions is slow

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Bas Schouten (:bas.schouten)]

We call this function a lot, every time we draw any text. It's slow due to it calling UsingClearType every time which calls the expensive SystemParameterInfo function. We can do better.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1325199: Only read system parameters for ClearType when we receive a paint event.

Review commit: https://reviewboard.mozilla.org/r/100274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100274/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8820884 [details]
Bug 1325199: Only read system parameters for ClearType when we receive a paint event.

https://reviewboard.mozilla.org/r/100274/#review100798

::: gfx/thebes/gfxDWriteFonts.cpp:53
(Diff revision 1)
>  #endif
>  
> +bool gfxDWriteFont::mUseClearType = true;
> +
>  static bool
>  UsingClearType()

Add a comment that this function is expensive and we only want to call it when we have to.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96cf05faacfe
Only read system parameters for ClearType when we receive a paint event. r=jrmuizel

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/96cf05faacfe