1325232 - Align the version in about: to the left

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Attachment: Nightly text hides the version

In the Nightly channel (tested on Hebrew), a portion of the y letter of "Nightly" in about: page partially hides the version itself.
Since the text in the logo is aligned to the left, we can also align the version's text to the left, even on RTL builds.

The code block that needs to be changed possibly in:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/about.css
is:
> #version {
>   font-weight: bold;
>   color: #909090;
>   margin: -24px 0 9px 17px;

A simple text-align: left would do the trick.

Comment 1

[Tomer Cohen :tomer]

Attachment: Bug 1325232 Align the version in about: to the left

Review commit: https://reviewboard.mozilla.org/r/100658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100658/

Comment 2

[Dão Gottwald [:dao]]

Can you please add a comment in the CSS rule explaining that this intentionally overrides the UI direction?

Comment 3

[Tomer Cohen :tomer]

(In reply to Dão Gottwald [:dao] from comment #2)
> Can you please add a comment in the CSS rule explaining that this
> intentionally overrides the UI direction?

Sure, no problem!

Comment 4

[Tomer Cohen :tomer]

Comment on attachment 8821354 [details]
Bug 1325232 Align the version in about: to the left

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100658/diff/1-2/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8821354 [details]
Bug 1325232 Align the version in about: to the left

https://reviewboard.mozilla.org/r/100658/#review101502

Comment 6

[:Gijs (he/him)]

Tomer, do you need help landing this? If so, just add the checkin-needed keyword.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf072e700371
Align the version in about: to the left r=dao

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/bf072e700371

Comment 9

[Itiel]

Seems fine in latest Nightly.

Comment 10

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 53.0a1.ar (2016.12.22) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 53.0a1 (2017.01.17) and Firefox 53.0a1.ar (2017.01.17) on Win 8.1 x64, Ubuntu 16.04 x64 and Mac OS X 10.9.5 .