1325297 - add a way to determine if a StartDecoding call resulted in a complete image and use it while painting

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Timothy Nikkel (:tnikkel)]

If we use async notifications (as we want to in bug 1317562) during painting, we will not be able to determine if the decoding we do during painting resulted in a complete image. So we add a way to tell so we can still draw the image in the current paint.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: create StartDecodingWithResult

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Use the result of StartDecodingWithResult during painting

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8821024 [details] [diff] [review]
create StartDecodingWithResult

Review of attachment 8821024 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/RasterImage.cpp
@@ +1061,5 @@
> +    return false;
> +  }
> +
> +  uint32_t flags = (aFlags & FLAG_ASYNC_NOTIFY) | FLAG_SYNC_DECODE_IF_FAST;
> +  DrawableSurface surface = RequestDecodeForSizeInternal(mSize, flags);  

nit: extra whitespace at end of line

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3382306ba5c5
Create a variant of imgIContainer::StartDecoding that returns if the current image frame is complete. r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/95f052c8d95a
Use the return value of StartDecoding to determine if an image finished decoding during painting. r=aosmond

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3382306ba5c5
https://hg.mozilla.org/mozilla-central/rev/95f052c8d95a