1325303 - [AS] [Telemetry] Track position of Top Sites interactions in the extras

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[:Grisha Kruglov]

When user clicks on a highlight, we track its position and total amount of highlights displayed.

We want to track position of a clicked top site as well. Total count is probably less useful here, as after some time it'll just converge on some query limit value.

To do this, we'll need to re-shuffle some onClick handlers between TopSiteCard and TopSite*Adaptor classes, similar to how this is handled by highlights.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1325303 - A-S Telemetry: track positions of Top Site items for tile and menu interactions

Review commit: https://reviewboard.mozilla.org/r/107698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107698/

Comment 2

[:Grisha Kruglov]

Attachment: Bug 1325303 - A-S Telemetry: track position of highlights for menu interactions

Review commit: https://reviewboard.mozilla.org/r/107700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107700/

Comment 3

[:Grisha Kruglov]

Attachment: Bug 1325303 - Adjust A-S telemetry docs to reflect greater use of action_position

Review commit: https://reviewboard.mozilla.org/r/107702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107702/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8831048 [details]
Bug 1325303 - A-S Telemetry: track positions of Top Site items for tile and menu interactions

https://reviewboard.mozilla.org/r/107698/#review108976

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/topsites/TopSitesPageAdapter.java:76
(Diff revision 1)
> +        final TopSite topSite = topSites.get(position);
> +        final int absolutePosition = getTopSiteAbsolutePosition(position);
> +
> +        ActivityStreamTelemetry.Extras.Builder extras = ActivityStreamTelemetry.Extras.builder()
> +                .forTopSite(topSite)
> +                .set(ActivityStreamTelemetry.Contract.ACTION_POSITION, absolutePosition);

Maybe the page number would be interesting too? For example item 5 can be on page 1 or page 2 and it could be interesting to know if people even swipe to see the next pages (like people tend to not go to the second page of search results).

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8831049 [details]
Bug 1325303 - A-S Telemetry: track position of highlights for menu interactions

https://reviewboard.mozilla.org/r/107700/#review108978

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8831050 [details]
Bug 1325303 - Adjust A-S telemetry docs to reflect greater use of action_position

https://reviewboard.mozilla.org/r/107702/#review108980

Comment 7

[:Grisha Kruglov]

(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> Maybe the page number would be interesting too? For example item 5 can be on
> page 1 or page 2 and it could be interesting to know if people even swipe to
> see the next pages (like people tend to not go to the second page of search
> results).

That certainly seems useful as we start digging into how this new UI is used. Tracking page number explicitly is nice, less ambiguous - I'll add it in.

Comment 8

[:Grisha Kruglov]

Comment on attachment 8831048 [details]
Bug 1325303 - A-S Telemetry: track positions of Top Site items for tile and menu interactions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107698/diff/1-2/

Comment 9

[:Grisha Kruglov]

Comment on attachment 8831049 [details]
Bug 1325303 - A-S Telemetry: track position of highlights for menu interactions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107700/diff/1-2/

Comment 10

[:Grisha Kruglov]

Comment on attachment 8831050 [details]
Bug 1325303 - Adjust A-S telemetry docs to reflect greater use of action_position

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107702/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd240b4d35d8
A-S Telemetry: track positions of Top Site items for tile and menu interactions r=sebastian
https://hg.mozilla.org/integration/autoland/rev/202a5b19143e
A-S Telemetry: track position of highlights for menu interactions r=sebastian
https://hg.mozilla.org/integration/autoland/rev/0b2b5e9cd091
Adjust A-S telemetry docs to reflect greater use of action_position r=sebastian

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cd240b4d35d8
https://hg.mozilla.org/mozilla-central/rev/202a5b19143e
https://hg.mozilla.org/mozilla-central/rev/0b2b5e9cd091