Closed Bug 1325319 Opened 7 years ago Closed 5 years ago

Implement isPointInFill() and isPointInStroke() methods of SVGGeometryElement

Categories

(Core :: SVG, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: sebo, Assigned: violet.bugreport)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

The SVGGeometryElement interface from the SVG 2 spec. has two methods isPointInFill() and isPointInStroke(), which still need to be implemented.

Sebastian
Blocks: svg2
Priority: -- → P3
Assignee: nobody → violet.bugreport
Status: NEW → ASSIGNED
Attached patch patch.patch (obsolete) — Splinter Review

My local repo has some weird problem, upload patch here to avoid data loss.
The patch is already complete anyway.

Attachment #9069236 - Attachment is obsolete: true

Cameron, could you review the 2-line webidl change in this patch? The actual implementation in SVG was already reviewed, now it just needs the approval from a webidl peer. The webidl change adds isPointInFill() and isPointInStroke() interface, which other browsers have already added long ago. Thanks.

Flags: needinfo?(cam)
Pushed by violet.bugreport@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/13d68d184214
Implement isPointInFill() and isPointInStroke() for SVGGeometryElement r=longsonr,bzbarsky
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17470 for changes under testing/web-platform/tests

I've created a PR to update the browser compatibility data and added examples to the isPointInFill() and isPointInStroke() pages. They're also already mentioned in the Firefox 69 release notes.

Sebastian

Flags: needinfo?(cam)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: