1325330 - [EME][Fennec] Create MediaCrypto object inside GeckoMediaDrmBridge's constructor.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Kilik Kuo [:kikuo] (inactive)]

Potential decryption failure! MediaCodec may get null MediaCrypto object.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1325330 - [EME][Fennec] Create MediaCrypto object inside GeckoMediaDrmBridge's constructor.

Review commit: https://reviewboard.mozilla.org/r/100770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100770/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8821464 [details]
Bug 1325330 - [EME][Fennec] Create MediaCrypto object inside GeckoMediaDrmBridge's constructor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100770/diff/1-2/

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8821464 [details]
Bug 1325330 - [EME][Fennec] Create MediaCrypto object inside GeckoMediaDrmBridge's constructor.

https://reviewboard.mozilla.org/r/100770/#review101228

Thanks, LGTM.  Not sure if you need another reviewer to land this or not.

::: mobile/android/base/java/org/mozilla/gecko/media/GeckoMediaDrmBridgeV21.java:39
(Diff revision 2)
>      private static final String INVALID_SESSION_ID = "Invalid";
>      private static final String WIDEVINE_KEY_SYSTEM = "com.widevine.alpha";
>      private static final boolean DEBUG = false;
>      private static final UUID WIDEVINE_SCHEME_UUID =
>          new UUID(0xedef8ba979d64aceL, 0xa3c827dcd51d21edL);
> +    private final int MAX_PROMISE_ID = Integer.MAX_VALUE;

nit : static

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8821464 [details]
Bug 1325330 - [EME][Fennec] Create MediaCrypto object inside GeckoMediaDrmBridge's constructor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100770/diff/2-3/

Comment 5

[James Cheng[:JamesCheng]]

Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e4f8410c08c
[EME][Fennec] Create MediaCrypto object inside GeckoMediaDrmBridge's constructor. r=kikuo

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8e4f8410c08c