1325335 - (hacl-eddsa) Integrate HACL* EdDSA over Curve25519

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Franziskus Kiefer [:franziskus]]

Tracking implementation of EdDSA.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Should we morph this into a HACL* bug?

Comment 3

[Phabricator Automation]

Attachment: HACL* ED25519

Comment 5

[Marcin Cieślak (:saper)]

Can we update the description of this bug so that it includes Curve25519, Curve25519 or Curve448, Ed448 keywords? I was searching bugzilla for all EC-related bugs and could not find this one (and filed https://bugzilla.mozilla.org/show_bug.cgi?id=1644232 as a result)

Comment 6

[Maciej S. Szmigiero]

One this bug is resolved it will be possible to use X.509 certs with ED25519 public key for TLS in Firefox and Thunderbird, right?

Comment 7

[Maciej S. Szmigiero]

One this bug is resolved
"Once this bug is resolved..."

Comment 8

[Benjamin Beurdouche [:beurdouche]]

Not immediately, because it will require some work for TLS and we don’t support those in 1.3. I have to double check but I am don’t think Ed25519 certs are allowed by the CAB forum either. This is also why we haven’t spent the effort yet. But I’d like to add the code in NSS in the next few months since we have the code.

Comment 9

[Maciej S. Szmigiero]

Not immediately, because it will require some work for TLS and we don’t support those in 1.3.

I guess that effort will be then tracked in a separate bug?

I have to double check but I am don’t think Ed25519 certs are allowed by the CAB forum either.

I was thinking more of TLS client certs here rather than ones issued by some public CA.

But I’d like to add the code in NSS in the next few months since we have the code.

Great, thanks!

Comment 10

[Rishabh Kumar]

(In reply to Benjamin Beurdouche [:beurdouche] from comment #8)

Not immediately, because it will require some work for TLS and we don’t support those in 1.3. I have to double check but I am don’t think Ed25519 certs are allowed by the CAB forum either. This is also why we haven’t spent the effort yet. But I’d like to add the code in NSS in the next few months since we have the code.

Hi Benjamin,

Do you have plans for adding the complete code for supporting EdDSA (all 4 layers of NSS) ??

Comment 11

[Rishabh Kumar]

Attachment: Bug 1325335 - Adding EdDSA implementation.

Comment 12

[Rishabh Kumar]

Attachment: Bug 1325335 - Parsing Public Key Structure (EDDSAPublicKey) for Signature Verification.

Depends on D113702

Comment 13

[Rishabh Kumar]

Attachment: Bug 1325335 - nss/lib layer code for EDDSA.

Depends on D113702

Comment 14

[Rishabh Kumar]

Attachment: WIP: Bug 1325335 - changes in nss/lib.

Comment 15

[Rishabh Kumar]

Attachment: Bug 1325335 - nss/lib code for EDDSA.

Comment 16

[Rishabh Kumar]

Attachment: Bug 1325335 - nss/lib code without CKK_EC_EDWARDS.

Depends on D117430

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 18

[Javier Fernandez]

I'm planing to work on the implementation of Ed25519 and X25519 algorithms for the WebCrypto API, but I believe we would need to complete the implementation of the crypto primitives in NSS, which I believe is the goal goal of this bug.;Is still active ? What are the plans for it ?

It seems Chrome and WebKit are actively working on the implementation of both algorithms, so it'd be great to catch up with them and avoid future interoperability issues.

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:beurdouche, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 20

[Anna Weine]

Attachment: Bug 1325335 - Updating HACL* to 0f136f28935822579c244f287e1d2a1908a7e552

Comment 21

[John Schanck [:jschanck]]

Attachment: Bug 1325335 - add EdDSA wycheproof tests. r=nkulatova

Depends on D116940

Comment 22

[Anna Weine]

Attachment: WIP: Bug 1325335 - Supporting WebCrypto TV form of TVs.

Depends on D200883

Comment 23

[Anna Weine]

https://hg.mozilla.org/projects/nss/rev/2e6af48abc8cd47565375dc69e46ec3b4d8aca93

https://hg.mozilla.org/projects/nss/rev/32a3a13682627f918da890af25d2b0a0d59d59af

Comment 24

[Anna Weine]

Attachment: Bug 1325335 - Removing check for message len in ed25519

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)