1325356 - [EME][Fennec] Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Kilik Kuo [:kikuo] (inactive)]

http://searchfox.org/mozilla-central/rev/ac40ca3ec39efe85bfb111274c10ee4ceea5bb7a/dom/media/platforms/android/MediaCodecDataDecoder.cpp#132

This object should exist in the derived class EMEVideoDataDecoder, not the base one.

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

Review commit: https://reviewboard.mozilla.org/r/100724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100724/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8821431 [details]
Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

https://reviewboard.mozilla.org/r/100724/#review101226

Is there a compile warning for hiding base members?

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8821431 [details]
Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

https://reviewboard.mozilla.org/r/100724/#review101226

Nope, just traced and found it.
Thanks !

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72f2f33715b4
Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. r=jwwang

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72f2f33715b4

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/803ec03e6791
Backed out changeset 72f2f33715b4 for failing tests it added a=backout

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c702cd7fb3ba
Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. r=jwwang

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Pulsebot from comment #6)
(In reply to Pulsebot from comment #7)
I accidentally backed this out instead of a different patch, then relanded this. It already made its way to m-c with the original changeset. When the backout and the relanding get merged to m-c, it'll probably comment in here again.

Sorry for the churn.

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c702cd7fb3ba