[EME][Fennec] Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kikuo, Assigned: kikuo)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
http://searchfox.org/mozilla-central/rev/ac40ca3ec39efe85bfb111274c10ee4ceea5bb7a/dom/media/platforms/android/MediaCodecDataDecoder.cpp#132

This object should exist in the derived class EMEVideoDataDecoder, not the base one.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8821431 [details]
Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

https://reviewboard.mozilla.org/r/100724/#review101226

Is there a compile warning for hiding base members?
Attachment #8821431 - Flags: review?(jwwang) → review+
(Assignee)

Comment 3

a year ago
mozreview-review-reply
Comment on attachment 8821431 [details]
Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.

https://reviewboard.mozilla.org/r/100724/#review101226

Nope, just traced and found it.
Thanks !

Comment 4

a year ago
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72f2f33715b4
Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. r=jwwang
Priority: -- → P3

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/72f2f33715b4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Comment 6

a year ago
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/803ec03e6791
Backed out changeset 72f2f33715b4 for failing tests it added a=backout

Comment 7

a year ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c702cd7fb3ba
Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. r=jwwang
(In reply to Pulsebot from comment #6)
(In reply to Pulsebot from comment #7)
I accidentally backed this out instead of a different patch, then relanded this. It already made its way to m-c with the original changeset. When the backout and the relanding get merged to m-c, it'll probably comment in here again.

Sorry for the churn.
You need to log in before you can comment on or make changes to this bug.