1325490 - Eclipse project generation should give a helpful error message if 'eclipse' is not in the PATH

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Botond Ballo [:botond]]

STR:
  1. Check out a fresh clone of m-c (or mozilla-unified)
  2. Run './mach build'
  3. Run './mach build-backend -b CppEclipse'

This results in the following exception:

$ ./mach build-backend -b CppEclipse
 0:00.08 /home/botond/dev/projects/mozilla/central/obj-x86_64-pc-linux-gnu/_virtualenv/bin/python /home/botond/dev/projects/mozilla/central/obj-x86_64-pc-linux-gnu/config.status --backend CppEclipse
Reticulating splines...
Traceback (most recent call last):
  File "/home/botond/dev/projects/mozilla/central/obj-x86_64-pc-linux-gnu/config.status", line 1230, in <module>
    config_status(**args)
  File "/home/botond/dev/projects/mozilla/central/python/mozbuild/mozbuild/config_status.py", line 150, in config_status
    the_backend.consume(definitions)
  File "/home/botond/dev/projects/mozilla/central/python/mozbuild/mozbuild/backend/base.py", line 143, in consume
    self.consume_finished()
  File "/home/botond/dev/projects/mozilla/central/python/mozbuild/mozbuild/backend/cpp_eclipse.py", line 127, in consume_finished
    self._import_project()
  File "/home/botond/dev/projects/mozilla/central/python/mozbuild/mozbuild/backend/cpp_eclipse.py", line 143, in _import_project
    "-data", self._workspace_dir, "-importAll", self._project_dir])
  File "/usr/lib/python2.7/subprocess.py", line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Comment 1

[Botond Ballo [:botond]]

The problems appears to be that eclipse is not in my PATH.

So, not broken, but could give a much better error message.

Comment 2

[Gregory Szorc [:gps]]

Eclipse project generation is definitely an under-loved feature. BenWa was the de-facto maintainer. But he's no longer active. I'd love to see someone step up to "own" the feature. As module owner, I'd have no problem delegating review privileges (possibly via sub-module) to people willing to maintain the various IDE integrations. We just need people to step forward...

Comment 3

[Botond Ballo [:botond]]

As a heavy user of Eclipse for C++ development, I've been meaning to spend some time looking at our C++ project generation code. (I still have a post-landing r? flag on bug 973770, which introduced the support, as a reminder to myself to familiarize myself with the code, in preparation for fixing bugs in it / making improvements to it. I just haven't gotten around to it yet...)

I'm happy to park this bug with me for now.

Comment 4

[Gregory Szorc [:gps]]

Thank you for taking an interest, Botond! I'm not an Eclipse user, but if there is anything I can do to help, let me know. And I'm sure you know there are plenty of people you can ping in #build.

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1325490 - Give a helpful error message if eclipse project generation is invoked and 'eclipse' is not in the PATH.

Review commit: https://reviewboard.mozilla.org/r/218552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218552/

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8949152 [details]
Bug 1325490 - Give a helpful error message if eclipse project generation is invoked and 'eclipse' is not in the PATH.

https://reviewboard.mozilla.org/r/218552/#review224348

Sure!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57bbf2bbcf9
Give a helpful error message if eclipse project generation is invoked and 'eclipse' is not in the PATH. r=nalexander

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e57bbf2bbcf9