1325516 - Failures in 2.0.0/deqp/functional/gles3/negativebufferapi.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1325516 - Simplify IMPL_COLOR_READ_FORMAT/TYPE and ensure that we only return valid ones. -

Review commit: https://reviewboard.mozilla.org/r/100696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100696/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1325516 - Misc fixes. -

Review commit: https://reviewboard.mozilla.org/r/100698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100698/

Comment 3

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8821397 [details]
Bug 1325516 - Simplify IMPL_COLOR_READ_FORMAT/TYPE and ensure that we only return valid ones. -

https://reviewboard.mozilla.org/r/100696/#review101376

r+ after fixing the GL_IMPLEMENTATION_COLOR_READ_TYPE issue

::: dom/canvas/WebGLContextGL.cpp:1444
(Diff revision 1)
> +    if (!gl->IsSupported(gl::GLFeature::ES2_compatibility))
> +        return defaultPI;
> +
> +    webgl::PackingInfo implPI;
> +    gl->fGetIntegerv(LOCAL_GL_IMPLEMENTATION_COLOR_READ_FORMAT, (GLint*)&implPI.format);
> +    gl->fGetIntegerv(LOCAL_GL_IMPLEMENTATION_COLOR_READ_FORMAT, (GLint*)&implPI.type);

Here should be GL_IMPLEMENTATION_COLOR_READ_TYPE?

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8821398 [details]
Bug 1325516 - Misc fixes. -

https://reviewboard.mozilla.org/r/100698/#review101382

r+ after fixing the opening issue.

::: dom/canvas/WebGLFramebuffer.cpp:1262
(Diff revision 1)
>  ////
>  
> +static bool
> +IsDrawBufferEnum(const WebGLContext* webgl, GLenum val)
> +{
> +

It seems to be redundant function? Please remove it.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8821397 [details]
Bug 1325516 - Simplify IMPL_COLOR_READ_FORMAT/TYPE and ensure that we only return valid ones. -

https://reviewboard.mozilla.org/r/100696/#review101376

> Here should be GL_IMPLEMENTATION_COLOR_READ_TYPE?

Absolutely!

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8821398 [details]
Bug 1325516 - Misc fixes. -

https://reviewboard.mozilla.org/r/100698/#review101382

> It seems to be redundant function? Please remove it.

Yep.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a10fa45d8ea
(flattened) - Misc fixes and simplify IMPL_COLOR_READ_FORMAT/TYPE and ensure that we only return valid ones. - r=daoshengmu

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a10fa45d8ea

Comment 9

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d2153ad43c9

Comment 10

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa55f9a67c76