If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

stylo: Add a mach command to make doing sync easier

RESOLVED WORKSFORME

Status

()

Core
Build Config
RESOLVED WORKSFORME
9 months ago
7 months ago

People

(Reporter: xidorn, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox53 affected)

Details

(Reporter)

Description

9 months ago
According to heycam, this command should probably do:
1. update the in-tree binding files
2. run the stylo tests
(Reporter)

Comment 1

9 months ago
Running the stylo tests seems hard than I thought. I'm not sure what is the right way to add that.

I tried to add stylo_tests as a dependency of gkrust-gtest, and running "cargo test -p stylo_tests" with "CARGO_TARGET_DIR" and "--target" specified. But it seems to end up rebuilding lots of things, and eventually fails on build-time bindgen because no MOZ_DIST is passed in this time.

I don't know why it rebuilds that lots of things, but I suppose that is because I don't pass in the exactly same flags as Gecko's build system. But Gecko's build system invokes cargo via makefile.

So I guess I probably need to add a makefile target which invokes the proper test, and let the mach command to call that target. But that seems a bit too complicated for me to hack :/
Assignee: xidorn+moz → nobody
Xidorn, do we still need this bug now that servo/servo is in mozilla-central?
Flags: needinfo?(xidorn+moz)
Blocks: 1243581
(Reporter)

Comment 3

7 months ago
Somehow yes, for updating the binding files for Servo's geckolib build. If one day we no longer need those in-tree binding files, we don't need to do anything here.

I'm not sure how heycam and manish do sync after we have s/s in m-c. Do they still update those binding files? Probably copying the files from obj dir isn't a large burden so it isn't worth adding something to make it easier?
Flags: needinfo?(xidorn+moz)
We're not using incubator anymore.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.