1325593 - Assertion failure: desc != internal_error, at tls13con.c:153

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

found via bughunter topsite tests and reproduced on latest aurora tinderbox windows debug build

STR:
-> Load https://www.lvme.me (bughunter reports also https://www.elwatannews.com) 
--> Assertion failure

Assertion failure: desc != internal_error, at c:/builds/moz2_slave/m-aurora-w32-d-000000000000000/build/src/security/nss/lib/ssl/tls13con.c:153

Comment 1

[Carsten Book [:Tomcat]]

marking as s-s bug just in case

Comment 2

[Carsten Book [:Tomcat]]

https://www.referralkey.com is another url the topsites found

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

tls13_SendClientSecondRound() -> ssl3_FlushHandshakeMessages() -> ssl3_SendRecord() -> ssl_DefSend() is returning a PR_CONNECT_RESET_ERROR, and we assert. We probably just shouldn't assert when the peer closed the connection.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

I think the best solution would be to uplift the patch from bug 1322496.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://nss-review.dev.mozaws.net/D130

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Uplifted to the NSS 3.28 branch:

https://hg.mozilla.org/projects/nss/rev/68243206a653

Comment 7

[Kai Engert [:KaiE:]]

Tim, can this be marked fixed?

Should the target milestone set to 3.28.1 ?

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

I think we should mark this as fixed as soon as 3.28.1 hits Aurora (52).

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Bug 1328600 got uplifted to 52 + 51.