1325603 - perf_autocomplete.js appears to be a test, but isn't actually run

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Mark Banner (:standard8)]

Bug 446247 initially added perf_autocomplete.js, then bug 370117 added test_autocomplete.js.

They are both similar copies of each other, but do differ.

We should work out if perf_autocomplete.js should be being run or not.

MattN: As you added both of these files, any ideas?

Comment 1

[Matthew N. [:MattN]]

(In reply to Mark Banner (:standard8, afk, back 3rd Jan) from comment #0)
> Bug 446247 initially added perf_autocomplete.js, then bug 370117 added
> test_autocomplete.js.
> 
> They are both similar copies of each other, but do differ.
> 
> We should work out if perf_autocomplete.js should be being run or not.

It should not since it's only useful during development to measure the performance of satchel. It's not a pass/fail type test. I think in the meantime there was some work to do performance testing outside of talos (i.e. from the test suites) and I guess this could be reporting results to whatever aggregates them (PerfHerder?) but it's probably not worth it. In case it's not clear, it was not intended to run in automation since it would just be a waste of CPU if the people running it aren't interested in the perf numbers.

IIRC, this file is probably broken with some of the satchel refactorings. Confirmed:

> TypeError: fac.autoCompleteSearch is not a function

So I'm fine deleting it. We haven't had any complaints about form history speed since the work in 2009 as far as I can remember. We can bring the file back from VCS history if it's useful in the future.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1325603 - Remove broken perf_autocomplete.js local performance test.

Review commit: https://reviewboard.mozilla.org/r/100810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100810/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8821576 [details]
Bug 1325603 - Remove broken perf_autocomplete.js local performance test.

https://reviewboard.mozilla.org/r/100810/#review101342

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f95e3018e089
Remove broken perf_autocomplete.js local performance test. r=MattN

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f95e3018e089