132563 - Print job options dialog should use paper name instead of paper size to set/get the selected paper size

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Roland Mainz]

Print job options dialog should use paper name instead of paper size to set/get
the selected paper size.
Otherwise we can choose the wrong paper when they have nearly the same size (for
example: "na-letter" is w=209.55,h=273.05 and "quarto" is w=209.55,h=268.732 -
the current print job options dialog picks whatever it finds first).

A more serious issue is the tray selection where we have the same paper sizes
which reside in different trays. Our current code doesn't allow it to choose a
tray... ;-(

Comment 1

[Roland Mainz]

Attachment: Prototype for 2002-03-18-08-trunk

Missing parts:
- GTK+ gfx support (only Xlib is implemented yet)
- PostScript module does not look at the paper name

ToDo (maybe for another bug):
Other platforms should use the paper name instead of the paper size, too...

Comment 2

[Roland Mainz]

Attachment: Patch for 2002-03-18-08-trunk

Changes:
- Both Xprint and PostScript module now find their paper size by name
(PostScript module still has the old code as fallback for platforms which do
not use nsIPrintSettings::SetPaperName() (Mac?!))
- PostScript module now uses the printerfeatures stuff, too (e.g. only print
options supported by the PostScript module are listed in the print dialog)
- Moved printerfeatures to new nsPrinterFeatures class (better abstraction).
- Integrated fix for bug 130075 ("Page headers and footers outside printable
region on almost all default printer setups") into patch
- Added new API to XprintUtil to get the list of setable/changeable attributes
as a flag field. This saves a lot of extra queries
- Various fixes for issues in InitPrintSettingsFromPrinter()
- Fixed a lot of issues in the print job options dialog (for example, we did
not set the "printer_"-prefix before the printer name for printer-specific
attributes - and we missed the '.' after the printer name, too)

Notes for review:
gfx/src/gtk/nsDeviceContextSpecG.cpp and gfx/src/gtk/nsDeviceContextSpecG.h are
copies of mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.cpp and
mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.h (only the class names have been
changed from "Xlib" to "GTK" - that's all). You only need to review one copy.

Comment 3

[rods (gone)]

Comment on attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

r=rods, looks good.

Comment 4

[Marc Attinasi]

Comment on attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

sr=attinasi (hoping someday, Roland will send me a _small_ patch...)

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 7

[sujay]

Roland, please verify...thanks!

Comment 8

[sujay]

Roland, please verify...thanks.

Comment 9

[Roland Mainz]

Verifying using a 2002-03-31-08-trunk build on Solaris2.7/SPARC ...

Comment 10

[rsbrux]

This is not fixed. The new print dialog (at least in Firefox 96.0 under Ubuntu) is still missing numerous standard paper sizes, e.g. the European standard paper size A4. A3 B5 and B6 (which are far less common) are listed, but A4 (the nearest European equivalent to U.S. letter size) is not.
The list of paper sizes has an inordicate number of paper sizes by absolute dimensions and an extremely short list of named paper sizes in comparison to the "system print dialog"!

Comment 11

[Dianna Smith [:diannaS]]

(In reply to rsbrux from comment #10)

This is not fixed. The new print dialog (at least in Firefox 96.0 under Ubuntu) is still missing numerous standard paper sizes, e.g. the European standard paper size A4. A3 B5 and B6 (which are far less common) are listed, but A4 (the nearest European equivalent to U.S. letter size) is not.
The list of paper sizes has an inordicate number of paper sizes by absolute dimensions and an extremely short list of named paper sizes in comparison to the "system print dialog"!

:rsbrux could you please file a different bug for the issue you are having so that we can properly triage it? This bug was closed 20yrs ago.