Print job options dialog should use paper name instead of paper size to set/get the selected paper size

VERIFIED FIXED in mozilla1.0

Status

()

Core
Printing: Output
--
critical
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Roland Mainz, Assigned: Roland Mainz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.0
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
Print job options dialog should use paper name instead of paper size to set/get
the selected paper size.
Otherwise we can choose the wrong paper when they have nearly the same size (for
example: "na-letter" is w=209.55,h=273.05 and "quarto" is w=209.55,h=268.732 -
the current print job options dialog picks whatever it finds first).

A more serious issue is the tray selection where we have the same paper sizes
which reside in different trays. Our current code doesn't allow it to choose a
tray... ;-(
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Depends on: 127646
Target Milestone: --- → mozilla1.0
(Assignee)

Updated

16 years ago
No longer depends on: 127646
(Assignee)

Updated

16 years ago
Depends on: 127646
(Assignee)

Comment 1

16 years ago
Created attachment 75427 [details] [diff] [review]
Prototype for 2002-03-18-08-trunk

Missing parts:
- GTK+ gfx support (only Xlib is implemented yet)
- PostScript module does not look at the paper name

ToDo (maybe for another bug):
Other platforms should use the paper name instead of the paper size, too...
(Assignee)

Comment 2

16 years ago
Created attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

Changes:
- Both Xprint and PostScript module now find their paper size by name
(PostScript module still has the old code as fallback for platforms which do
not use nsIPrintSettings::SetPaperName() (Mac?!))
- PostScript module now uses the printerfeatures stuff, too (e.g. only print
options supported by the PostScript module are listed in the print dialog)
- Moved printerfeatures to new nsPrinterFeatures class (better abstraction).
- Integrated fix for bug 130075 ("Page headers and footers outside printable
region on almost all default printer setups") into patch
- Added new API to XprintUtil to get the list of setable/changeable attributes
as a flag field. This saves a lot of extra queries
- Various fixes for issues in InitPrintSettingsFromPrinter()
- Fixed a lot of issues in the print job options dialog (for example, we did
not set the "printer_"-prefix before the printer name for printer-specific
attributes - and we missed the '.' after the printer name, too)

Notes for review:
gfx/src/gtk/nsDeviceContextSpecG.cpp and gfx/src/gtk/nsDeviceContextSpecG.h are
copies of mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.cpp and
mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.h (only the class names have been
changed from "Xlib" to "GTK" - that's all). You only need to review one copy.
Attachment #75427 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Keywords: patch, review
(Assignee)

Updated

16 years ago
Blocks: 130075

Comment 3

16 years ago
Comment on attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

r=rods, looks good.
Attachment #75725 - Flags: review+

Comment 4

16 years ago
Comment on attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

sr=attinasi (hoping someday, Roland will send me a _small_ patch...)
Attachment #75725 - Flags: superreview+

Comment 5

16 years ago
Comment on attachment 75725 [details] [diff] [review]
Patch for 2002-03-18-08-trunk

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75725 - Flags: approval+
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 7

16 years ago
Roland, please verify...thanks!

Comment 8

16 years ago
Roland, please verify...thanks.
(Assignee)

Comment 9

16 years ago
Verifying using a 2002-03-31-08-trunk build on Solaris2.7/SPARC ...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.