1325663 - Can no longer build using MSVC 2015

Status: RESOLVED WORKSFORME

(Core :: DOM: Events, defect)

Description

[Bill Gianopoulos [:WG9s]]

Attachment: Build log showing errors

Windows builds fail using MSVC 2015.  Se attached errors.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: Build log showing errors

Oops that was the worng file.

Comment 2

[Bill Gianopoulos [:WG9s]]

BTW.  In case you do not know me about regression bugs I post I AM bisecting this.

Comment 3

[Bill Gianopoulos [:WG9s]]

Hg bisect reveled this:

The first bad revision is:
changeset:   326989:f397c3444f2a
user:        Stone Shih <[e-mail]>
date:        Sun Nov 20 10:24:46 2016 +0800
summary:     Bug 1031362 Part1: Dispatching mouse events by handling pen generated WM_POINTER* messages. r=jimm,smaug

Comment 4

[Bill Gianopoulos [:WG9s]]

Verified via backout that the checkin for bug 1031362 is the regressor.

Comment 5

[Ming-Chou Shih [:stone]]

Attachment: Add include headers to prevent build fail with vc2015 on win10

Comment 6

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dd7345b21d587a0e3f78bffdaa4e900ef315d08

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to Ming-Chou Shih [:stone] from comment #5)
> Created attachment 8821704 [details] [diff] [review]
> Add include headers to prevent build fail with vc2015 on win10

With this patch applied, my Windows 32 build completed successfully!

Thanks!

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> (In reply to Ming-Chou Shih [:stone] from comment #5)
> > Created attachment 8821704 [details] [diff] [review]
> > Add include headers to prevent build fail with vc2015 on win10
> 
> With this patch applied, my Windows 32 build completed successfully!
> 
> Thanks!

My windows 64-bit build also completed successfully.

Once again many thanks for coming up with a fix so quickly!

Comment 9

[Bill Gianopoulos [:WG9s]]

I am curious as to why this is not an issue with the official builds.  I try to duplicate the official build environment.

Comment 10

[Ming-Chou Shih [:stone]]

Comment on attachment 8821704 [details] [diff] [review]
Add include headers to prevent build fail with vc2015 on win10

Thanks for that jwatt already submitted a patch for the failure.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9329689b3f83

Comment 11

[Ming-Chou Shih [:stone]]

It's fixed in https://hg.mozilla.org/mozilla-central/rev/9329689b3f83