Can no longer build using MSVC 2015

RESOLVED WORKSFORME

Status

()

Core
DOM: Events
--
blocker
RESOLVED WORKSFORME
a year ago
a year ago

People

(Reporter: WG9s, Assigned: stone)

Tracking

({regression})

Trunk
x86_64
Windows 10
regression
Points:
---

Firefox Tracking Flags

(firefox53 affected)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

a year ago
Created attachment 8821580 [details]
Build log showing errors

Windows builds fail using MSVC 2015.  Se attached errors.
(Reporter)

Comment 1

a year ago
Created attachment 8821581 [details]
Build log showing errors

Oops that was the worng file.
Attachment #8821580 - Attachment is obsolete: true
(Reporter)

Comment 2

a year ago
BTW.  In case you do not know me about regression bugs I post I AM bisecting this.
(Reporter)

Comment 3

a year ago
Hg bisect reveled this:

The first bad revision is:
changeset:   326989:f397c3444f2a
user:        Stone Shih <sshih@mozilla.com>
date:        Sun Nov 20 10:24:46 2016 +0800
summary:     Bug 1031362 Part1: Dispatching mouse events by handling pen generated WM_POINTER* messages. r=jimm,smaug
Blocks: 1031362
(Reporter)

Comment 4

a year ago
Verified via backout that the checkin for bug 1031362 is the regressor.
(Assignee)

Updated

a year ago
Assignee: nobody → sshih
(Reporter)

Updated

a year ago
Assignee: sshih → nobody
Component: Widget: Win32 → DOM: Events
(Reporter)

Updated

a year ago
Assignee: nobody → sshih
(Reporter)

Updated

a year ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

a year ago
Created attachment 8821704 [details] [diff] [review]
Add include headers to prevent build fail with vc2015 on win10
(Assignee)

Updated

a year ago
Attachment #8821704 - Flags: review?(jmathies)
(Reporter)

Comment 7

a year ago
(In reply to Ming-Chou Shih [:stone] from comment #5)
> Created attachment 8821704 [details] [diff] [review]
> Add include headers to prevent build fail with vc2015 on win10

With this patch applied, my Windows 32 build completed successfully!

Thanks!
(Reporter)

Comment 8

a year ago
(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> (In reply to Ming-Chou Shih [:stone] from comment #5)
> > Created attachment 8821704 [details] [diff] [review]
> > Add include headers to prevent build fail with vc2015 on win10
> 
> With this patch applied, my Windows 32 build completed successfully!
> 
> Thanks!

My windows 64-bit build also completed successfully.

Once again many thanks for coming up with a fix so quickly!
(Reporter)

Comment 9

a year ago
I am curious as to why this is not an issue with the official builds.  I try to duplicate the official build environment.
(Assignee)

Comment 10

a year ago
Comment on attachment 8821704 [details] [diff] [review]
Add include headers to prevent build fail with vc2015 on win10

Thanks for that jwatt already submitted a patch for the failure.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9329689b3f83
Attachment #8821704 - Attachment is obsolete: true
Attachment #8821704 - Flags: review?(jmathies)
(Assignee)

Comment 11

a year ago
It's fixed in https://hg.mozilla.org/mozilla-central/rev/9329689b3f83
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.