Closed Bug 1325900 Opened 8 years ago Closed 5 years ago

Centralize the LoadFlags setting of workers

Categories

(Core :: DOM: Service Workers, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: bhsu, Unassigned)

References

Details

As comment 35 of bug 1299209 suggests, we should centralize the LoadFlags setting of a WorkerPrivate. We are going to set the LoadFlags of a WorkerPrivate when it is created instead of acquire it when trying to load the script.
Depends on: 1299209
Assignee: nobody → bhsu
Blocks: 1290944
No longer depends on: 1299209
Priority: -- → P3
Assignee: bhsu → nobody

:asuth, do we still want/need this though the bug this was blocking is already resolved?

Flags: needinfo?(bugmail)

I think we still want to do more cleanup around worker script loading and how it populates its WorkerLoadInfo and its mLoadFlags, but I think:

  • Bug 1353636 addressed the ugliest parts of what was going by switching to an enum that more closely matched the spec.
  • There's no clear next step for this bug, and I think overhauling the script loader in bug 1384285 (or whatever related bug it happens on) will likely involve cleaning the situation up and have a more clear place to do that.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(bugmail)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.