1325917 - force-cargo-library-build does not honour path to Rust in $PATH but seems to assume $HOME/.cargo/bin

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1323901 +++

From bug 1323901 comment #12:

C:\mozilla-build\msys\etc\profile.d\profile-rustup.sh
assumes that Rust was installed in $HOME/.cargo/bin.

It should not assume this since the Windows installer rustup-init.exe lets you install anywhere you want. Even if you install into C:\Users\user\.cargo\bin you might have a different $HOME for the Mozilla compilation (which I do since I need to sync my development environment onto various machines, and I only sync the "Mozilla home" which are a few files and not the "Windows home" which are gigabytes of so-called app data).

After removing C:\mozilla-build\msys\etc\profile.d\profile-rustup.sh and setting
export PATH=/c/users/jorgk/.cargo/bin:$PATH
in my profile, I still get:

 2:49.38 force-cargo-library-build
 2:49.39 env: c:/mozilla-source/.cargo/bin/cargo.exe: No such file or directory

Comment 1

[(not currently active) Ted Mielczarek]

profile-rustup.sh is written by `mach bootstrap`:
https://dxr.mozilla.org/mozilla-central/rev/57ac9f63fc6953f4efeb0cc84a60192d3721251f/python/mozboot/mozboot/mozillabuild.py#35

It should only do so if it actually installs rustup. The build system simply invokes $(CARGO), where that variable comes from configure, so if you've modified your PATH you will need to re-run configure `./mach configure` to pick up those changes.

Comment 2

[Nathan Froyd [:froydnj]]

I *think* comment 1 implies that this is not a bug.  I'm not 100% sure, though; please reopen if you think there's still a problem with the build system.