Closed Bug 1325970 Opened 9 years ago Closed 9 years ago

Wrong width of element with `display: flow-root`

Categories

(Core :: Layout: Block and Inline, defect)

Product:
Core
Component:
Layout: Block and Inline
Version:
53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox52 --- unaffected
firefox53 + fixed

People

(Reporter: mtanalin, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: testcase)

Attachments

(3 files)

Testcase
470 bytes, text/html
Details
Treat display:flow-root as a block-ish frame type.
943 bytes, patch
dholbert
: review+
Details | Diff | Splinter Review
More display:flow-root tests
2.47 KB, patch
Details | Diff | Splinter Review
Attached file Testcase —
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20161220004019 Steps to reproduce: Width of the element that has `display: flow-root` (implemented recently, see the bug 1322191) is not 100% of its parent block, but depends on actual-content width instead (like a table). Please see the attached testcase. According to the spec [1], the `display: flow-root` is equivalent to `display: block flow-root`, so an element that was originally block-level should continue behaving as block-level one, and the only effect of `display: flow-root` for such element should be clearing floats the element contains. Tested in the latest Firefox Nightly (20161227030213). The bug is reproducible in both single-process and e10s modes. [1] https://drafts.csswg.org/css-display-3/#display-value-summary
Blocks: 1322191
Component: Untriaged → CSS Parsing and Computation
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
Status: UNCONFIRMED → NEW
Ever confirmed: true
Yeah, that's definitely a bug.
Assignee: nobody → mats
Component: CSS Parsing and Computation → Layout: Block and Inline
Keywords: testcase
[Tracking Requested - why for this release]: We shouldn't ship bug 1322191 without this fix, so we should either fix this for Firefox 53 or back out bug 1322191.
status-firefox52: --- → unaffected
status-firefox53: --- → affected
tracking-firefox53: --- → ?
This feature is behind a pref, so simply disabling it would also be an alternative.
Comment on attachment 8822084 [details] [diff] [review] Treat display:flow-root as a block-ish frame type. Review of attachment 8822084 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8822084 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/29ec9f18e524 Treat display:flow-root as a block-ish frame type. r=dholbert https://hg.mozilla.org/integration/mozilla-inbound/rev/57920d928ac9 More display:flow-root tests.
Flags: in-testsuite+
Tracking 53+ per Comment 2.
tracking-firefox53: ? → +
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: