Closed
Bug 1326003
Opened 7 years ago
Closed 6 years ago
Is WebAudioDecodeJob::mContentType needed?
Categories
(Core :: Web Audio, defect, P5)
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: mozbugz, Assigned: maxime.langlade)
References
Details
Attachments
(2 files)
Found while working on revamping all media-content-type strings: http://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_mozilla%3A%3AWebAudioDecodeJob%3E_2&redirect=false WebAudioDecodeJob::mContentType is initialized on construction, but then never used apart from calculating the WebAudioDecodeJob object size! It was first introduced in bug 792263 with the same apparent degree of usage. (Maybe it was useful for debugging then, or was destined for greater things?)
|
||
Comment 2•6 years ago
|
||
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•6 years ago
|
Assignee: nobody → maxime.langlade
|
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8913696 [details] Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType. https://reviewboard.mozilla.org/r/185114/#review190130
Attachment #8913696 -
Flags: review?(padenot)
|
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8913695 [details] Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType. https://reviewboard.mozilla.org/r/185112/#review190134 Looks good, thanks!
Attachment #8913695 -
Flags: review?(padenot) → review+
Pushed by paul@paul.cx: https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4c2ecdb38c Remove dead code: WebAudioDecodeJob::mContentType. r=padenot
Pushed by paul@paul.cx: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a9b51d1eb83 Fix callsite on a CLOSED TREE.
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aa4c2ecdb38c https://hg.mozilla.org/mozilla-central/rev/1a9b51d1eb83
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•