Is WebAudioDecodeJob::mContentType needed?

RESOLVED FIXED in Firefox 58

Status

()

Core
Web Audio
P5
normal
Rank:
45
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: gerald, Assigned: maxime.langlade)

Tracking

49 Branch
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Found while working on revamping all media-content-type strings:
http://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_mozilla%3A%3AWebAudioDecodeJob%3E_2&redirect=false

WebAudioDecodeJob::mContentType is initialized on construction, but then never used apart from calculating the WebAudioDecodeJob object size!

It was first introduced in bug 792263 with the same apparent degree of usage. (Maybe it was useful for debugging then, or was destined for greater things?)
Sounds easy to remove.
Rank: 45
Priority: -- → P4
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Updated

4 months ago
Assignee: nobody → maxime.langlade

Comment 5

4 months ago
mozreview-review
Comment on attachment 8913696 [details]
Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

https://reviewboard.mozilla.org/r/185114/#review190130
Attachment #8913696 - Flags: review?(padenot)

Comment 6

4 months ago
mozreview-review
Comment on attachment 8913695 [details]
Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

https://reviewboard.mozilla.org/r/185112/#review190134

Looks good, thanks!
Attachment #8913695 - Flags: review?(padenot) → review+

Comment 7

4 months ago
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4c2ecdb38c
Remove dead code: WebAudioDecodeJob::mContentType. r=padenot

Comment 9

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aa4c2ecdb38c
https://hg.mozilla.org/mozilla-central/rev/1a9b51d1eb83
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.