1326003 - Is WebAudioDecodeJob::mContentType needed?

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P5)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Found while working on revamping all media-content-type strings:
http://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_mozilla%3A%3AWebAudioDecodeJob%3E_2&redirect=false

WebAudioDecodeJob::mContentType is initialized on construction, but then never used apart from calculating the WebAudioDecodeJob object size!

It was first introduced in bug 792263 with the same apparent degree of usage. (Maybe it was useful for debugging then, or was destined for greater things?)

Comment 1

[Andreas Pehrson [:pehrsons]]

Sounds easy to remove.

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P4->P5 to align with new Mozilla triage process.

Comment 3

[maxime.langlade]

Attachment: Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

Review commit: https://reviewboard.mozilla.org/r/185112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185112/

Comment 4

[maxime.langlade]

Attachment: Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

Review commit: https://reviewboard.mozilla.org/r/185114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185114/

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 8913696 [details]
Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

https://reviewboard.mozilla.org/r/185114/#review190130

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8913695 [details]
Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

https://reviewboard.mozilla.org/r/185112/#review190134

Looks good, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4c2ecdb38c
Remove dead code: WebAudioDecodeJob::mContentType. r=padenot

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a9b51d1eb83
Fix callsite on a CLOSED TREE.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aa4c2ecdb38c
https://hg.mozilla.org/mozilla-central/rev/1a9b51d1eb83