Is WebAudioDecodeJob::mContentType needed?

RESOLVED FIXED in Firefox 58

Status

()

defect
P5
normal
Rank:
45
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: gerald, Assigned: maxime.langlade)

Tracking

49 Branch
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(2 attachments)

Found while working on revamping all media-content-type strings:
http://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_mozilla%3A%3AWebAudioDecodeJob%3E_2&redirect=false

WebAudioDecodeJob::mContentType is initialized on construction, but then never used apart from calculating the WebAudioDecodeJob object size!

It was first introduced in bug 792263 with the same apparent degree of usage. (Maybe it was useful for debugging then, or was destined for greater things?)
Sounds easy to remove.
Rank: 45
Priority: -- → P4
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5
Assignee: nobody → maxime.langlade
Comment on attachment 8913696 [details]
Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

https://reviewboard.mozilla.org/r/185114/#review190130
Attachment #8913696 - Flags: review?(padenot)
Comment on attachment 8913695 [details]
Bug 1326003 - Remove dead code: WebAudioDecodeJob::mContentType.

https://reviewboard.mozilla.org/r/185112/#review190134

Looks good, thanks!
Attachment #8913695 - Flags: review?(padenot) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4c2ecdb38c
Remove dead code: WebAudioDecodeJob::mContentType. r=padenot
https://hg.mozilla.org/mozilla-central/rev/aa4c2ecdb38c
https://hg.mozilla.org/mozilla-central/rev/1a9b51d1eb83
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.