Closed Bug 1326032 Opened 9 years ago Closed 9 years ago

deezer.com Impossible to login, app unusable

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
53 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
platform-rel --- +

People

(Reporter: kubrick, Unassigned)

References

Details

(Whiteboard: [platform-rel-Deezer])

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20161227030213 Steps to reproduce: Go to https://www.deezer.com/en/, click on "Log in" Actual results: Nothing, The console shows: ReferenceError: module is not defined[Learn More] external-773b8b4a0ea3ac16ce27988dfe190fd1.js:1:8500 Error: Cannot find module 'react' cdm-a4b998b124bbcf871341292001da7b22.js:1:7545 Error: Cannot find module 'jquery' cdm-a4b998b124bbcf871341292001da7b22.js:1:7545 ReferenceError: facebook is not defined[Learn More] en:642:3 ReferenceError: tracking is not defined[Learn More] en:693:2 TypeError: window.googleplus is undefined[Learn More] en:613:2 ReferenceError: home is not defined[Learn More] Expected results: Firefox should display the login page. Testes & broken in safe mode too and with multiprocess disabled too. Works on Chrome, older firefox versions, etc.
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Regression range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=732548de4aad&tochange=81f871e19f1f possibly a regression from "global" proposal, bug 1317422. There are several "typeof global" expression: https://e-cdns-files.dzcdn.net/cache/js/external-773b8b4a0ea3ac16ce27988dfe190fd1.js not sure where the code comes from tho, maybe a dupe of bug 1325907.
Blocks: globalThis
Status: UNCONFIRMED → NEW
Component: Untriaged → JavaScript Engine
Ever confirmed: true
Product: Firefox → Core
See Also: → 1325907
Since all of that output is browserified (grep for module ID 39, called "./global"), I'm not sure why that would be breaking.
The responsible code here is: "undefined" != typeof window && (window.BrowserDetect = BrowserDetect), "undefined" != typeof global && (module.exports = BrowserDetect) So what happens is that `"undefined" != typeof global` is true now, so they try to assign module.exports = BrowserDetect, but module doesn't exist.
Good call - can we get in contact with them to find out where that code is coming from, and potentially fix it?
Being a Deezer paying customer, I shall open a ticket with their support pointing them to this bug report.
FYI, the same regression range broke Jira in Bug 1328218
Deezer support informed me that they forwarded my message to their development team so they can have a look at it. The change has been backed for fear of user exodus, see bug 1317422 comment 17.
See Also: → 1328218
platform-rel: --- → ?
Whiteboard: [platform-rel-Deezer]
platform-rel: ? → +
I'm gonna close this as INVALID, since the global stuff was backed out.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.