1326131 - stylo: Handle CSS variables in AnimationValue

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Manish Goregaokar [:manishearth]]

Bug 1317208 adds `AnimationValue` to Servo but doesn't handle CSS variable values in the constructor from property declaration blocks. This should be fixed.

Comment 1

[Boris Chiou [:boris]]

There are some wpt tests crashed because of this bug, I think.

error message:
 0:08.94 PROCESS_OUTPUT: ProcessReader (pid:44792) "thread '<unnamed>' panicked at 'not yet implemented', [path to objdir]/toolkit/library/x86_64-apple-darwin/debug/build/style-ffe1341867262ac3/out/properties.rs:63850"

in properties.rs:
 63847                     PropertyDeclaration::Left(ref val) => {
 63848                         let computed = match *val {
 63849                             // https://bugzilla.mozilla.org/show_bug.cgi?id=1326131
 63850                             DeclaredValue::WithVariables(_) => unimplemented!(),

Crashed test files:
1. web-animations/interface/Animation/animate.html
2. web-animations/interface/KeyframeEffect/constructor.html
3. web-animations/interface/KeyframeEffect/setKeyframes.html

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Bug 1336668 is the bug that Gecko implemented css variable animations.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

I meant bug 1268858.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40611785badcce1db41d570761bc0be48584f21a

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1326131 - Make AnimationValue::from_declaration return computed CSS variable.

In Gecko, we resolve CSS variables when we generate keyframes for each
animations (i.e. when we create script animations, when we create/update CSS
animations). AnimationValue::from_declaration is only called in both cases.

Review commit: https://reviewboard.mozilla.org/r/126554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126554/

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8854597 [details]
Bug 1326131 - Make AnimationValue::from_declaration return computed CSS variable.

https://reviewboard.mozilla.org/r/126554/#review129136

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thank you Manish!
https://github.com/servo/servo/pull/16263

Comment 8

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/integration/autoland/rev/8337b3954450