1326209 - Change background-color to use complex color

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1326209 part 1 - Make nsCSSRendering::DrawTableBorderSegment take nscolor for background color.

Review commit: https://reviewboard.mozilla.org/r/101350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101350/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1326209 part 2 - Change background-color to use complex color.

Review commit: https://reviewboard.mozilla.org/r/101352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101352/

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8822433 [details]
Bug 1326209 part 1 - Make nsCSSRendering::DrawTableBorderSegment take nscolor for background color.

https://reviewboard.mozilla.org/r/101350/#review101912

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8822434 [details]
Bug 1326209 part 2 - Change background-color to use complex color.

https://reviewboard.mozilla.org/r/101352/#review101922

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Ah, this change turns the non-fatal assertion bug 871758 into a fatal assertion...

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

With patch to bug 894245, it seems everything is fine now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fcfb59d512f5b55a006857f4f8ec3edfb508b3c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e09adfc32294
part 1 - Make nsCSSRendering::DrawTableBorderSegment take nscolor for background color. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/064f7ee8484a
part 2 - Change background-color to use complex color. r=dholbert

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e09adfc32294
https://hg.mozilla.org/mozilla-central/rev/064f7ee8484a