1326472 - Compile warning introduced by bug 1309596

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Stephen A Pohl [:spohl]]

0:05.95 Warning: -Wnonnull in /Users/Stephen/Documents/mozilla-central/widget/cocoa/nsDragService.mm: null passed to a callee that requires a non-null argument
 0:05.95 /Users/Stephen/Documents/mozilla-central/widget/cocoa/nsDragService.mm:695:17: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
 0:05.95       [aSession enumerateDraggingItemsWithOptions:NSDraggingItemEnumerationConcurrent
 0:05.95                 ^
 0:06.76 1 warning generated.

Comment 1

[Markus Stange [:mstange]]

Uh oh. I think we can pass mNativeDragView to forView: and @{} to searchOptions:.

Comment 2

[Neil Deakin]

I think it is the null searchOptions that causes this, despite Apple examples using nil as well.

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Patch

It looks indeed like this compile warning is caused by a null searchOptions. This may have been incorrectly marked as requiring a non-null argument by Apple (see https://forums.developer.apple.com/thread/17954). This patch fixes the warning.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8823666 [details] [diff] [review]
Patch

Review of attachment 8823666 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should pass something to forView as well. Do you know why it's not warning for that argument?

Comment 5

[Stephen A Pohl [:spohl]]

Attachment: Patch

I don't, but your suggestion sounds good.

Comment 6

[Neil Deakin]

The documentation for enumerateDraggingItemsWithOptions says that "A view value of nil means the screen coordinate space.", but doesn't mention that nil is allowed for searchOptions.

Comment 7

[Neil Deakin]

Comment on attachment 8823668 [details] [diff] [review]
Patch

So setting both to nil won't work since the coordinates are now incorrect.

Comment 8

[Markus Stange [:mstange]]

Ah, I see.

Comment 9

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/494e4664f600d8b1e66ab462af720358d7472e46
Bug 1326472: Fix compile warning introduced by bug 1309596. r=mstange

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/494e4664f600