1326496 - Build support for Linux alpha broken

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[John Paul Adrian Glaubitz]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161201031821

Steps to reproduce:

When trying to build Firefox on Linux/alpha, the build fails with [1]:

checking for 64-bit OS... yes
Traceback (most recent call last):
  File "../configure.py", line 107, in <module>
    sys.exit(main(sys.argv))
  File "../configure.py", line 26, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 260, in run
    func(*args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 302, in _value_for
    return self._value_for_depends(obj)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/util.py", line 925, in method_call
    cache[args] = self.func(instance, *args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 329, in _value_for_depends
    return func(*resolved_args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 773, in wrapped
    return new_func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/moz.configure/toolchain.configure", line 793, in check_have_64_bit
    configure_error('The target compiler does not agree with configure '
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 773, in wrapped
    return new_func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/moz.configure/util.configure", line 19, in configure_error
    raise ConfigureError(message)
mozbuild.configure.ConfigureError: The target compiler does not agree with configure about the target bitness.

This is fixed by the attached patch which properly matches alpha as a 64-bit architecture. Additional patches fix issues with locating the C library (libc.so.6.1) on alpha as well as enable the PowerPC atomic operations for alpha.

Comment 1

[John Paul Adrian Glaubitz]

Attachment: 0001-No-1326496-mozbuild-Fix-bitness-from-32-to-64-bits-o.patch

Comment 2

[John Paul Adrian Glaubitz]

Attachment: 0002-No-1326496-js-jit-Use-PowerPC-atomic-operations-on-a.patch

Comment 3

[John Paul Adrian Glaubitz]

Attachment: 0003-No-1326496-testing-mochitest-Use-find_library-to-get.patch

Comment 4

[John Paul Adrian Glaubitz]

Attachment: 0004-No-1326496-testing-mozbase-Use-find_library-to-get-l.patch

Comment 5

[John Paul Adrian Glaubitz]

Attachment: 0001-Bug-1326496-mozbuild-Fix-bitness-from-32-to-64-bits-.patch

Comment 6

[John Paul Adrian Glaubitz]

Attachment: 0002-Bug-1326496-js-jit-Use-PowerPC-atomic-operations-on-.patch

Comment 7

[John Paul Adrian Glaubitz]

Attachment: 0003-Bug-1326496-testing-mochitest-Use-find_library-to-ge.patch

Comment 8

[John Paul Adrian Glaubitz]

Attachment: 0004-Bug-1326496-testing-mozbase-Use-find_library-to-get-.patch

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1326496 - mozbuild: Fix bitness from 32 to 64 bits on alpha.

Review commit: https://reviewboard.mozilla.org/r/103784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103784/

Comment 10

[Mike Hommey [:glandium]]

Attachment: Bug 1326496 - js:jit: Use PowerPC atomic operations on alpha.

Review commit: https://reviewboard.mozilla.org/r/103786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103786/

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1326496 - testing:mochitest: Use find_library to get libc filename.

On architectures like alpha and ia64, the glibc does not use the
canonical ABI version number 6 but 6.1 and therefore the filename
of the C library is not libc.so.6 but libc.so.6.1. We're therefore
making the Python code more flexible and use find_library from
ctypes.util to determine the filename from the environment instead
of hard-coding it.

Review commit: https://reviewboard.mozilla.org/r/103788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103788/

Comment 12

[Mike Hommey [:glandium]]

Attachment: Bug 1326496 - testing:mozbase: Use find_library to get libc filename.

On architectures like alpha and ia64, the glibc does not use the
canonical ABI version number 6 but 6.1 and therefore the filename
of the C library is not libc.so.6 but libc.so.6.1. We're therefore
making the Python code more flexible and use find_library from
ctypes.util to determine the filename from the environment instead
of hard-coding it.

Review commit: https://reviewboard.mozilla.org/r/103790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103790/

Comment 13

[Mike Hommey [:glandium]]

Comment on attachment 8825678 [details]
Bug 1326496 - mozbuild: Fix bitness from 32 to 64 bits on alpha.

https://reviewboard.mozilla.org/r/103784/#review104486

Comment 14

[John Paul Adrian Glaubitz]

Attachment: 0002-Bug-1326496-js-jit-Use-PowerPC-atomic-operations-on-.patch

This replaces the other patch in line with Jan's comment here [1].

> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1325495#c11

Comment 15

[Andrew Halberstadt [:ahal]]

Comment on attachment 8825680 [details]
Bug 1326496 - testing:mochitest: Use find_library to get libc filename.

https://reviewboard.mozilla.org/r/103788/#review104558

Lgtm.

Comment 16

[Andrew Halberstadt [:ahal]]

Comment on attachment 8825681 [details]
Bug 1326496 - testing:mozbase: Use find_library to get libc filename.

https://reviewboard.mozilla.org/r/103790/#review104560

Comment 17

[Mike Hommey [:glandium]]

Comment on attachment 8825678 [details]
Bug 1326496 - mozbuild: Fix bitness from 32 to 64 bits on alpha.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103784/diff/1-2/

Comment 18

[Mike Hommey [:glandium]]

Comment on attachment 8825679 [details]
Bug 1326496 - js:jit: Use PowerPC atomic operations on alpha.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103786/diff/1-2/

Comment 19

[Mike Hommey [:glandium]]

Comment on attachment 8825680 [details]
Bug 1326496 - testing:mochitest: Use find_library to get libc filename.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103788/diff/1-2/

Comment 20

[Mike Hommey [:glandium]]

Comment on attachment 8825681 [details]
Bug 1326496 - testing:mozbase: Use find_library to get libc filename.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103790/diff/1-2/

Comment 21

[Jan de Mooij [:jandem]]

Comment on attachment 8825679 [details]
Bug 1326496 - js:jit: Use PowerPC atomic operations on alpha.

https://reviewboard.mozilla.org/r/103786/#review105146

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9e61617c8c9
mozbuild: Fix bitness from 32 to 64 bits on alpha. r=glandium
https://hg.mozilla.org/integration/autoland/rev/f8856b758312
js:jit: Use PowerPC atomic operations on alpha. r=jandem
https://hg.mozilla.org/integration/autoland/rev/156ce27e0e11
testing:mochitest: Use find_library to get libc filename. r=ahal
https://hg.mozilla.org/integration/autoland/rev/ef5bd9f2e0cb
testing:mozbase: Use find_library to get libc filename. r=ahal

Comment 23

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b9e61617c8c9
https://hg.mozilla.org/mozilla-central/rev/f8856b758312
https://hg.mozilla.org/mozilla-central/rev/156ce27e0e11
https://hg.mozilla.org/mozilla-central/rev/ef5bd9f2e0cb