Closed Bug 1326496 Opened 3 years ago Closed 3 years ago

Build support for Linux alpha broken

Categories

(Firefox Build System :: General, defect)

51 Branch
defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: glaubitz, Assigned: glaubitz)

Details

Attachments

(4 files, 9 obsolete files)

59 bytes, text/x-review-board-request
glandium
: review+
Details
59 bytes, text/x-review-board-request
jandem
: review+
Details
59 bytes, text/x-review-board-request
ahal
: review+
Details
59 bytes, text/x-review-board-request
ahal
: review+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161201031821

Steps to reproduce:

When trying to build Firefox on Linux/alpha, the build fails with [1]:

checking for 64-bit OS... yes
Traceback (most recent call last):
  File "../configure.py", line 107, in <module>
    sys.exit(main(sys.argv))
  File "../configure.py", line 26, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 260, in run
    func(*args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 302, in _value_for
    return self._value_for_depends(obj)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/util.py", line 925, in method_call
    cache[args] = self.func(instance, *args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 329, in _value_for_depends
    return func(*resolved_args)
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 773, in wrapped
    return new_func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/moz.configure/toolchain.configure", line 793, in check_have_64_bit
    configure_error('The target compiler does not agree with configure '
  File "/<<PKGBUILDDIR>>/python/mozbuild/mozbuild/configure/__init__.py", line 773, in wrapped
    return new_func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/moz.configure/util.configure", line 19, in configure_error
    raise ConfigureError(message)
mozbuild.configure.ConfigureError: The target compiler does not agree with configure about the target bitness.

This is fixed by the attached patch which properly matches alpha as a 64-bit architecture. Additional patches fix issues with locating the C library (libc.so.6.1) on alpha as well as enable the PowerPC atomic operations for alpha.
Attachment #8822772 - Flags: review?(mh+mozilla)
Attachment #8822772 - Flags: review?(martin)
Attachment #8822773 - Flags: review?(mh+mozilla)
Attachment #8822773 - Flags: review?(martin)
Attachment #8822774 - Flags: review?(mh+mozilla)
Attachment #8822774 - Flags: review?(martin)
Attachment #8822776 - Flags: review?(mh+mozilla)
Attachment #8822776 - Flags: review?(martin)
Attachment #8822772 - Attachment is obsolete: true
Attachment #8822772 - Flags: review?(mh+mozilla)
Attachment #8822772 - Flags: review?(martin)
Attachment #8822778 - Flags: review?(mh+mozilla)
Attachment #8822778 - Flags: review?(martin)
Attachment #8822773 - Attachment is obsolete: true
Attachment #8822773 - Flags: review?(mh+mozilla)
Attachment #8822773 - Flags: review?(martin)
Attachment #8822779 - Flags: review?(mh+mozilla)
Attachment #8822779 - Flags: review?(martin)
Attachment #8822774 - Attachment is obsolete: true
Attachment #8822774 - Flags: review?(mh+mozilla)
Attachment #8822774 - Flags: review?(martin)
Attachment #8822780 - Flags: review?(mh+mozilla)
Attachment #8822780 - Flags: review?(martin)
Attachment #8822776 - Attachment is obsolete: true
Attachment #8822776 - Flags: review?(mh+mozilla)
Attachment #8822776 - Flags: review?(martin)
Attachment #8822781 - Flags: review?(mh+mozilla)
Attachment #8822781 - Flags: review?(martin)
Component: Untriaged → Build Config
Product: Firefox → Core
Attachment #8822778 - Attachment is obsolete: true
Attachment #8822778 - Flags: review?(mh+mozilla)
Attachment #8822778 - Flags: review?(martin)
Attachment #8822779 - Attachment is obsolete: true
Attachment #8822779 - Flags: review?(mh+mozilla)
Attachment #8822779 - Flags: review?(martin)
Attachment #8822780 - Attachment is obsolete: true
Attachment #8822780 - Flags: review?(mh+mozilla)
Attachment #8822780 - Flags: review?(martin)
Attachment #8822781 - Attachment is obsolete: true
Attachment #8822781 - Flags: review?(mh+mozilla)
Attachment #8822781 - Flags: review?(martin)
Assignee: nobody → glaubitz
Comment on attachment 8825678 [details]
Bug 1326496 - mozbuild: Fix bitness from 32 to 64 bits on alpha.

https://reviewboard.mozilla.org/r/103784/#review104486
Attachment #8825678 - Flags: review?(mh+mozilla) → review+
This replaces the other patch in line with Jan's comment here [1].

> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1325495#c11
Attachment #8825795 - Flags: review?(jdemooij)
Comment on attachment 8825680 [details]
Bug 1326496 - testing:mochitest: Use find_library to get libc filename.

https://reviewboard.mozilla.org/r/103788/#review104558

Lgtm.
Attachment #8825680 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8825681 [details]
Bug 1326496 - testing:mozbase: Use find_library to get libc filename.

https://reviewboard.mozilla.org/r/103790/#review104560
Attachment #8825681 - Flags: review?(ahalberstadt) → review+
Attachment #8825795 - Attachment is obsolete: true
Attachment #8825795 - Flags: review?(jdemooij)
Comment on attachment 8825679 [details]
Bug 1326496 - js:jit: Use PowerPC atomic operations on alpha.

https://reviewboard.mozilla.org/r/103786/#review105146
Attachment #8825679 - Flags: review?(jdemooij) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/b9e61617c8c9
mozbuild: Fix bitness from 32 to 64 bits on alpha. r=glandium
https://hg.mozilla.org/integration/autoland/rev/f8856b758312
js:jit: Use PowerPC atomic operations on alpha. r=jandem
https://hg.mozilla.org/integration/autoland/rev/156ce27e0e11
testing:mochitest: Use find_library to get libc filename. r=ahal
https://hg.mozilla.org/integration/autoland/rev/ef5bd9f2e0cb
testing:mozbase: Use find_library to get libc filename. r=ahal
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.