Rename nsIURI.path to something less confusing

RESOLVED FIXED in Firefox 57

Status

()

Core
Networking
RESOLVED FIXED
11 months ago
3 months ago

People

(Reporter: emk, Assigned: emk)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

50 Branch
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [necko-backlog])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
+++ This bug was initially created as a clone of Bug #1323683 +++

1. Add an alias of nsIURI.path (e.g. .pathQueryRef).
2. Remove in-tree use of .path.
3. Deprecate .path.
4. Remove .path completely (probably after Firefox 57).
(Assignee)

Updated

4 months ago
Blocks: 1347507
(Assignee)

Comment 1

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cef9c02f34b7e580698e3994720ed479764d5a0
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

Comment 3

4 months ago
mozreview-review
Comment on attachment 8891800 [details]
Bug 1326520 - Rename nsIURI.path to pathQueryRef. .gosu

https://reviewboard.mozilla.org/r/162836/#review168144

Looks good. Do we have any (Mozilla-built) old style addons that we'll keep in 57? If so, we should make sure those are properly tested and/or updated.
Attachment #8891800 - Flags: review?(valentin.gosu) → review+
(Assignee)

Comment 4

4 months ago
mozreview-review-reply
Comment on attachment 8891800 [details]
Bug 1326520 - Rename nsIURI.path to pathQueryRef. .gosu

https://reviewboard.mozilla.org/r/162836/#review168144

According to the recent dev-platform discussion, we don't have to care about out-of-tree legacy addons in a post-57 world.
https://groups.google.com/forum/#!topic/mozilla.dev.platform/TqoheEOdm8w

Comment 5

4 months ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/509b327a4a10
Rename nsIURI.path to pathQueryRef. r=valentin.gosu

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/509b327a4a10
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1386996
(Assignee)

Updated

4 months ago
Depends on: 1387017

Updated

4 months ago
Depends on: 1387101
Comment hidden (advocacy)
Is there a reason the labeling on the diagram at http://searchfox.org/mozilla-central/rev/4d8e389498a08668cce9ebf6232cc96be178c3e4/netwerk/base/nsIURI.idl#16-28 wasn't modified in this bug?
Flags: needinfo?(VYV03354)
(Assignee)

Comment 9

3 months ago
No, I simply forgot to change the diagram.
Flags: needinfo?(VYV03354)
You need to log in before you can comment on or make changes to this bug.