1326520 - Rename nsIURI.path to something less confusing

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Masatoshi Kimura [:emk]]

+++ This bug was initially created as a clone of Bug #1323683 +++

1. Add an alias of nsIURI.path (e.g. .pathQueryRef).
2. Remove in-tree use of .path.
3. Deprecate .path.
4. Remove .path completely (probably after Firefox 57).

Comment 1

[Masatoshi Kimura [:emk]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cef9c02f34b7e580698e3994720ed479764d5a0

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1326520 - Rename nsIURI.path to pathQueryRef. .gosu

Review commit: https://reviewboard.mozilla.org/r/162836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162836/

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8891800 [details]
Bug 1326520 - Rename nsIURI.path to pathQueryRef. .gosu

https://reviewboard.mozilla.org/r/162836/#review168144

Looks good. Do we have any (Mozilla-built) old style addons that we'll keep in 57? If so, we should make sure those are properly tested and/or updated.

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8891800 [details]
Bug 1326520 - Rename nsIURI.path to pathQueryRef. .gosu

https://reviewboard.mozilla.org/r/162836/#review168144

According to the recent dev-platform discussion, we don't have to care about out-of-tree legacy addons in a post-57 world.
https://groups.google.com/forum/#!topic/mozilla.dev.platform/TqoheEOdm8w

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/509b327a4a10
Rename nsIURI.path to pathQueryRef. r=valentin.gosu

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/509b327a4a10

Comment 7

[Anthony Lieuallen]

Why does Mozilla keep breaking legacy extensions?  I'm trying to use what little open source development time I have to make a WebExt compatible port.  But I keep being forced to spend my time patching my old xul/xpcom extension because it keeps breaking.

Please roll this back and consider doing it some time after Firefox 57.  Same for any other xpcom change.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Is there a reason the labeling on the diagram at http://searchfox.org/mozilla-central/rev/4d8e389498a08668cce9ebf6232cc96be178c3e4/netwerk/base/nsIURI.idl#16-28 wasn't modified in this bug?

Comment 9

[Masatoshi Kimura [:emk]]

No, I simply forgot to change the diagram.