1326567 - Support peek and pop link preview (WKWebView) on iOS 10

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

When the allowsLinkPreview property is set to true, users can gently press on links to peek them, which loads the link in another view over the app and blurs the app in the background. We should support this.

Comment 1

[Bryan Munar (:bkmunar)]

This is cool but the only problem I see with this is that if a use wants to actually see the full site, they're going to be punted over to Safari (with the back button in the top left corner to go back to Firefox). Is this something we want? This sounds more like a UX/product issue. Flagging people to see what they think.

Comment 2

[Robin Andersen [:tecgirl]]

:bkmunar why would they be punted to Safari? we already support this on the tabs tray.

Comment 3

[Bryan Munar (:bkmunar)]

What Aaron is asking for is the Apple built in version of what we do in the Tabs Tray so it will punt it to Safari, not Firefox. I'm assuming we could still build the same functionality however, it would have to be custom made (which I think we have?).

Comment 4

[Bryan Munar (:bkmunar)]

https://developer.apple.com/reference/webkit/wkwebview/1415000-allowslinkpreview link for reference

Comment 5

[Aaron Train [:aaronmt]]

> ... if a user wants to actually see the full site

In Safari, on peek, there is no way to view the full site whilst holding down your finger. 

If you drag upwards you get 'Open in New Tab', 'Add to Reading List', 'Copy', 'Share'.

We should support the same.

Comment 6

[Aaron Train [:aaronmt]]

Testing this out locally (iPhone 7 iOS 10), if I manually set allowsLinkPreview to true on the WebView (Tab.Swift) this works beautifully ... however I need to also manually comment out our contextMenuHelper on the tab in the BVC to not compete for the long-press gesture.

I'm not sure how sometimes Safari shows the context menu on some links and on others it shows a link preview.

I'm sure there's a way to have both.

I tested via the big articles on http://osxdaily.com