59 bytes, text/x-review-board-request
PointerlockFsWarning.Timeout  was initially implemented as a class , but at that moment es6-class was not enabled on any channel other than Nightly, so it was eventually changed to use the tranditional manner. The traditional manner causes some issue when rewriting functions to use object-shorthand rule in bug 1325464. Given that we've had es6-class everywhere now, we can use that to make it clearer (and remove exception for eslint).  https://dxr.mozilla.org/mozilla-central/rev/81463aec62d02fa1915e03cda7a8ddc8d44c71fc/browser/base/content/browser-fullScreenAndPointerLock.js#12-30,45-49  https://reviewboard.mozilla.org/r/14841/diff/3/
Flags: needinfo?(leftysolara) → needinfo?(jaws)
Yeah, that looks right.
Assignee: nobody → leftysolara
Status: NEW → ASSIGNED
Comment on attachment 8824266 [details] Bug 1326581 - Rewrite PointerlockFsWarning.Timeout to use ES6-class. https://reviewboard.mozilla.org/r/102800/#review103484 Looks good, I'm not sure I understand why the Timeout prototype was needed to be delcared within a PointerlockFsWarning.init() function. :xidorn, is there something I'm missing or does this change look OK?
Attachment #8824266 - Flags: review?(jaws) → review+
2 years ago
I don't think there is any particular reason I have to put it in an init function. Probably we can also initialize Timeout.prototype in top level. I probably just wanted to avoid putting code there.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0c0de08391b4 Rewrite PointerlockFsWarning.Timeout to use ES6-class. r=jaws
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.