132669 - Date/time format is not following the system language format

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Yuying Long]

Build: 03-21 trunk build on Mac 10.1.3

Steps:
1. Launch browser and open Composer.
2. Open any local file or live web page.
3. Format | Page Title and Properties.

Notice the date/time format for Last Modified is in English.  By checking the
system reginal setting, it shows following by the OS language locale. - see a
followed screen shot.

We have date/time show in some other places, e.g. Page Info, Expired date in
Cookie Manager...etc.   They are all in OS language format.

But the data/time string here is a little bit different than those strings though.

Windows has similar problem too, but windows system date/time format seems
doesn't has the weekly name option.

Comment 1

[Yuying Long]

Attachment: screen shot

Comment 2

[nhottanscp]

Is this Macintosh specific?

Comment 3

[Yuying Long]

No, like I said before, windows has same problem.  Linux has a core bug 132665,
so can not verify right now.

Comment 4

[Kasumi]

No matter with OS nor regional setting, expression is the same as attachment.

Comment 5

[nhottanscp]

I think the editor code needs to use nsIDateTimeFormat.

Change component to Editor Composer and reassign.

Comment 6

[Rui Xu]

QA -> [e-mail] (Editor:Composer default)

Comment 7

[Syd Logan]

--> cmanske

Comment 8

[Frank Tang]

I have a patch for this. will be attached later. 

Comment 9

[Frank Tang]

Attachment: patch to fxi this problem

cmanske, could you r= this one ?

Comment 10

[Charles Manske]

Comment on attachment 79511 [details] [diff] [review]
patch to fxi this problem 

r=cmanske
I am unfamiliar with this interface, but it looks logical enough!
One question: why do you use "lastModDate.getMonth()+1"

Comment 11

[nhottanscp]

getMonth() returns number 0 to 11 while the date format interface expects 1 to
12 numbers.

Comment 12

[kinmoz]

Comment on attachment 79511 [details] [diff] [review]
patch to fxi this problem 

Do we really need a global for this

  +var gDateService = null;

if it's only used in the startup method of this modal dialog?

Also, since the date code execution is conditional, I'd prefer that we didn't
load the service unless we had to, so the code that gets the service should
probably move under the |if(Date.parse(lastmod))| block.

Comment 13

[Charles Manske]

Attachment: patch v2

Changes per Kin's comments. Also thought a try/catch was a good idea.

Comment 14

[nhottanscp]

Comment on attachment 80439 [details] [diff] [review]
patch v2

r=nhotta

Comment 15

[kinmoz]

Comment on attachment 80439 [details] [diff] [review]
patch v2

sr=[e-mail]

Comment 16

[Charles Manske]

checked in

Comment 17

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 18

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 19

[Charles Manske]

Checked into trunk.

Comment 20

[Yuying Long]

Verified fixed on 04-24 trunk build / Mac10.1.3.

Comment 21

[sujay]

ylong please also test on windows if you get chance...

then you can mark this one verified-fixed...thanks!

Comment 22

[Yuying Long]

Verified it has been fixed on windows too. (can not verify it on linux because
blocked by bug 132665)

I'm marking it as verified now.  But is there any chance we can get this
check-into branch?

Comment 23

[Jaime Rodriguez, Jr.]

Upping impact to [adt2 RTM]/nsbeta1+ as this is important to non-US english users.

Comment 24

[scottputterman]

adding adt1.0.0+.  Please get drivers approval and then check into the Mozilla
1.0 branch.

Comment 25

[Syd Logan]

when landed, please add fixed1.0.0 keyword

Comment 26

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch.  Please get drivers
approval before checking in.

Comment 27

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 80439 [details] [diff] [review]
patch v2

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 28

[Charles Manske]

checked into MOZILLA_1_0_BRANCH.

Comment 29

[sujay]

yuying can you also verify on the latest branch please?  thanks!

Comment 30

[Yuying Long]

Verified on 06-03 branch build on Mac OS X and WinXP-SC.