Closed Bug 1326712 Opened 8 years ago Closed 8 years ago

Bookmarks panel saves all changes if I press Enter when "Remove Bookmark" button is focused

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox52 --- verified
firefox53 --- verified

People

(Reporter: arni2033, Assigned: jaws)

References

Details

Attachments

(2 files)

Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup.
59 bytes, text/x-review-board-request
mossop
: review+
Details
1326712-aurora.patch
2.64 KB, patch
jcristau
: approval-mozilla-aurora+
Details | Diff | Splinter Review
>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160526082509 STR_1: 1. Press Ctrl+D to create new bookmark 2. Press Tab key several times to focus "Remove Bookmark" button 3. Press Enter AR: Bookmark stays ER: Bookmark should JUST GO AWAY!!! Feature that was almost deleted in bug 1219794 (see bug 1285684). Note: Instead of fixes/improvements of REAL bugs we have bug 1219794 completely ruined workflow & UX.
No longer blocks: 1277113
Component: Untriaged → Bookmarks & History
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8823434 - Flags: review?(gijskruitbosch+bugs) → review?(dtownsend)
Comment on attachment 8823434 [details] Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. https://reviewboard.mozilla.org/r/101950/#review102348 Looks good but we should add a test for this
Attachment #8823434 - Flags: review?(dtownsend) → review+
(In reply to Dave Townsend [:mossop] from comment #3) > Looks good but we should add a test for this Thanks, I added a test in the latest revision.
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83d895c1c1ea Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b14520ebf7cc Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
https://hg.mozilla.org/mozilla-central/rev/b14520ebf7cc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (32-bit) , Windows 8.1 (64-bit). This bug's fix is verified on Latest Nightly 53.0a1. Build ID : 20170112030301 User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 [bugday-20170111]
Does this want uplift to 52? (I'm guessing too late for 51, but up to you)
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
Flags: needinfo?(jaws)
Approval Request Comment [Feature/Bug causing the regression]: not a recent regression [User impact if declined]: users may accidentally keep a bookmark that they intended to remove [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: extra case added to condition for remove button [String changes made/needed]: none
Flags: needinfo?(jaws)
Attachment #8826322 - Flags: approval-mozilla-aurora?
Comment on attachment 8826322 [details] [diff] [review] 1326712-aurora.patch bookmark panel fix for aurora52 azmina721, maybe you can verify this fix once it is available in dev edition builds?
Flags: needinfo?(azmina721)
Attachment #8826322 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
needs rebasing for aurora
Flags: needinfo?(jaws)
The patch on the bug that has aurora-approval[1] was rebased for aurora. Did you have failures applying that patch? I just checked again and it rebased fine to aurora-tip. [1] https://bugzilla.mozilla.org/attachment.cgi?id=8826322
Flags: needinfo?(jaws) → needinfo?(cbook)
Flags: needinfo?(cbook)
I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (64-bit) on Windows 7 , 64 Bit ! This bug's fix is verified with latest Developer Edition (Aurora) Build ID 20170118004007 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 [bugday-20170118]
I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (64-bit) on ubuntu 16.10 , 64 Bit ! This bug's fix is verified with latest Developer Edition (Aurora) Build ID 20170118004007 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 [bugday-20170118]
I have verified this bug's fix on Latest Aurora 52.0 on Windows 8.1 (64-bit). And also, as per comment 19 & comment 20 the bug is now verified on Aurora 52.0 on both Windows & Linux. Marking it verified for Firefox Aurora.
status-firefox52: fixed → verified
Flags: needinfo?(azmina721)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: