1326845 - Reloading a page with iframe mess up the tab history

Status: RESOLVED DUPLICATE of bug 1326251

(Core :: DOM: Navigation, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open "testcase 1" in a new tab
2. Wait until the title of the tab changes to "1. Press F5"
3. Press F5
4. Right-click Back button in urlbar, then click item "0. Wait" in tab history

AR:  No visible action. Error [1] in console.
ER:  Either don't show me that history item, or do something sensible if it's shown


STR_2:
1. Copy url of "testcase 1" to clipboard
2. Open http://example.org
3. Right-click uribar, click "Paste and go"
4. Wait until the title of the tab changes to "1. Press F5"
5. Press F5, wait 4 seconds
6. Right-click Back button in urlbar, then click the lower item "0. Wait" in tab history
 (bonus) - there's already a bug, but if you continue, there'll be more
7. Click Forward button in urlbar or press Alt+Right
8. Click Forward button in urlbar or press Alt+Right
9. Right-click Back button in urlbar, then click on the 1st item in tab history ("1. Press F5")

AR:
 Step 6 - browser switched to the url from Step 2 (http://example.org)
 Step 8 - No visible action. Error [2] in console
 Step 9 - No visible action. Error [1] in console

ER:
 Either don't show me inactive forward button/history items, or do something sensible if they're shown
 Behavior of STR_2 Step 6 is not "sensible", because it opens wrong item, not the one I clicked


[1]
chrome://global/content/browser-child.js:304
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.gotoIndex]

[2]
chrome://global/content/browser-child.js:299
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.goForward]

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi arni2033, thanks for reporting this issue, but it seems "testcase 1" you mentioned in comment 0 is missing. Could you please attach it?

Comment 2

[arni2033]

Attachment: testcase 1 - Reloading a page with iframe mess up the tab history.html

Thanks

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This bug isn't existent on beta (FF50), sounds a regression during the period.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #3)
> This bug isn't existent on beta (FF50), sounds a regression during the
                                  ^^^^^^ typo, should be beta FF51
> period.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Its possible this is a regression from bug 1303167.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

[Tracking Requested - why for this release]:
User visible regression.

Comment 7

[Samael Wang [:freesamael] (away for now)]

I tried mozgression but couldn't find a good build even at 2011-ish builds. The symptom doesn't exist on latest aurora / beta so it's more likely to be a nightly-only bug than a regression.

It's making testing of bug 1326251 being difficult as I couldn't get correct history.length. I'll take the task to investigate it.

Comment 8

[Samael Wang [:freesamael] (away for now)]

I was wrong about the dependency. I'm still trying to figure out what happened but it's not related to the testing issue I encountered in bug 1326251. I was confused.

Comment 9

[Julien Cristau [:jcristau]]

Not tracking for 52 based on comment 7.

Comment 10

[Samael Wang [:freesamael] (away for now)]

We concluded that frame history entries should be removed on reloading in bug 1326251, so this bug should also be fixed by that change. I'll revalidate once the patch lands.

Comment 11

[Samael Wang [:freesamael] (away for now)]

Verified on latest nightly. Feel free to re-open if you still encounter the issue.