132798 - There are two RemoveWindow methods in nsWindowWatcher

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: APIs, defect)

Description

[timeless]

nsresult
nsWindowWatcher::RemoveWindow(nsWatcherWindowEntry *inInfo)
NS_IMETHODIMP
nsWindowWatcher::RemoveWindow(nsIDOMWindow *aWindow)

Is there a reason not to rename the nsresult one to RemoveWindowEntry ?

Comment 1

[timeless]

Attachment: rename function and make the code formatting a bit more consistent

Comment 2

[Dan M]

Is there any reason not to just leave this as is? It's a common C++ technique,
giving the same operation, but using different parameters to get to the same
data, the same name. Polymorphism makes it clear that multiple functions are
performing the same task. I don't see the advantage to giving these two methods
separate names.

Comment 3

[timeless]

It's a common C++ technique, but if I ever wanted to make that other method scriptable and expose it via xpcom, I couldn't because XPCOM doesn't allow it.

Comment 4

[Dan M]

I agree it's not script-copacetic. But it's unlikely that the other method (the
one that takes an nsWatcherWindowEntry) would ever be exposed to script. It's a
private method, and its nsWatcherWindowEntry parameter is so private it isn't
even defined in a .h file.