My impression is that this is not a regression, but please re-set if you do find a meaningful window.
Priority: -- → P3
>>> My Info: Win7_64, Nightly 29, 32bit, ID 20140107030202 (2014-01-07) Not reproducible (good) >>> My Info: Win7_64, Nightly 53, 32bit, ID 20170107030205 (2017-01-07) Reproducible (bad) I'm not sure whether this means that it's a regression, but it seems to be one.
Here is the regression window: Last good revision: e7a366c1036c (2014-01-07) First bad revision: cf2d1bd796ea (2014-01-08) Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7a366c1036c&tochange=cf2d1bd796ea
Regression window: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a58fd917dead&tochange=7d4182792214 Suspect: one of the followings 3f6e82f8f9f8 Tim Taubert — Bug 952998 - Use FrameTree to collect DOMSessionStorage data r=yoric 8cbf45406b30 Tim Taubert — Bug 952934 - Use onFrameTreeReset() to re-collect docShell capability data r=smacleod be6ad59e25f5 Tim Taubert — Bug 956724 - Fix broken onload handler for DOMWindows r=rnewman
Sorry, I don't work on this code anymore.
Flags: needinfo?(ttaubert) → needinfo?(mdeboer)
Flags: needinfo?(mdeboer) → needinfo?(jryans)
Flags: needinfo?(jryans) → needinfo?(mdeboer)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7) > Mike, can you think of use cases outside of DevTools where users would want > session restore to accurately restore disabled JS as it does today? No. I think not persisting this state in sessionstore is a fine move. > Is there any browser UI outside of DevTools that even allows disabling JS > per tab? No. This has been removed from browser UIs explicitly.
Hi Mike, Sure! I can work on this, thanks :-)
Assignee: nobody → wiwang
Attachment #8853378 - Flags: review?(mdeboer)
Attachment #8853378 - Flags: review?(mdeboer) → review-
Hi Mike, Thanks for your advice! Here is the revised patch, could you help to review? (Since MozReview will be placed, allow me to use the original one here? :) )
Attachment #8884766 - Flags: review?(mdeboer) → review+
Thank you for reviewing this belated patch, Mike!
Please help to land the patch, thanks! :)
I have reproduced this bug with Nightly 53.0a1 (2017-01-02) (64-bit) on Ubuntu 16.04 LTS! This bug's fix is now verified with latest Nightly! Build ID 20170717100212 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170712]
I have successfully reproduced this bug with Nightly 53.0a1 (2017-01-01) (32-bit) on windows 10(32bit) this bug is verified fix with latest nightly 56.0a1 (2017-07-17) (32-bit) Build ID: 20170717030207 Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0 [bugday-20170712]
You need to log in before you can comment on or make changes to this bug.