Open Bug 1328017 Opened 7 years ago Updated 2 years ago

Ruleview displays non-functional rules when style attribute is deleted/modified

Categories

(DevTools :: Inspector: Rules, defect, P2)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(Not tracked)

People

(Reporter: arni2033, Unassigned)

References

Details

(Keywords: regression) 

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open url   data:text/html,<textarea style="width: 206px;height: 102px;overflow: scroll;">
2. Open inspector -> ruleview, inspect <textarea>
3. Disable CSS rule "overflow: scroll;" in ruleview
4. Resize the textarea via resizer
5. Enable CSS rule "overflow: scroll;" in ruleview

AR:  The rule looks applied, but it's not
ER:  Should be applied


STR_2:
1. Open url [1]
2. Open devtools -> inspector -> ruleview
3. Delete [style] attribute of body element in markup
4. Click on checkbox at the left side of rule "color: red;" in ruleview to enable it
5. Switch to another element in markup and back

> [1] data:text/html,<body style="color:red"><b>hello_world

AR:
 Step 3 - the rule in ruleview is displayed as disabled
 Step 4 - the rule is displayed as enabled, but it is not applied (text on the page is black)
 Step 5 - no rules displayed in ruleview
ER:
 If ruleview displays rule as enabled, it should be applied on the page, and vice versa (4 options)
 Therefore, either X or Y.  X is better
 X) Step 4 - rule "color: red;" should be applied ([style] attribute should be created again)
 Y) Step 3 - no rules should be displayed in ruleview


This is regression from bug 1069829. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=8b4e5ab50377a26e6610f21a0f8233467de19e9b&tochange=eb721f4d509f8826886fea9716ce06903bd3af0d@ Patrick Brosset <:pbro> (PTO until Jan. 3rd):
It seems that this is a regresion caused by your change. Please have a look.
No longer blocks: 1277113
Component: Untriaged → Developer Tools: CSS Rules Inspector
In both cases I see stack traces in the browser console.
I think the essential issue is that there are changes being made
that aren't being picked up by the rule view.

In the "overflow" case, resizing the textarea removes the commented-out overflow property;
the rule view sees the size changes but doesn't notice that the property is now gone.
In the "color" case, the edit in the markup view removes the element style entirely.
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P2
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.