Closed Bug 1328115 Opened 3 years ago Closed 3 years ago

Crash in mozilla::jni::Context<T>::ClassRef

Categories

(Core :: Widget: Android, defect, critical)

Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: njn, Assigned: jchen)

References

Details

(Keywords: crash)

Crash Data

Attachments

(3 files)

This bug was filed from the Socorro interface and is 
report bp-68a4f982-d7bb-4554-b5ec-12af42161231.
=============================================================

#1 topcrash in Nightly 20161230030205, though it's only 6 crashes across two installations.

The crash address is always 0xdeadd00d, which is interesting. It's also a startup crash.

jchen, any ideas?
Flags: needinfo?(nchen)
Crashes are happening on API 15, because VsyncSource references several symbols that only exist on API 16+.
Flags: needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Don't go through the VsyncSource Java class to test support for vsync.
Because VsyncSource references symbols from API 16+, Dalvik fails to
load it for API 15 and below. Also make several other changes in
VsyncSource, including removing the unnecessary JNIObject superclass,
and refactoring the instance initialization code, which fixes a possible
race when initializing.
Attachment #8823778 - Flags: review?(snorp)
Be more careful when we try to find Java classes, so that any exceptions
are not ignored and passed on to the caller, which is likely to result
in a hard-to-diagnose Dalvik/ART crash.
Attachment #8823780 - Flags: review?(snorp)
Attachment #8823778 - Flags: review?(snorp) → review+
Attachment #8823780 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10968c7a6abf
1. Test vsync support in native code; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ddd36462bdf
2. Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6416404aea
3. Check for exceptions when finding Java class; r=snorp
https://hg.mozilla.org/mozilla-central/rev/10968c7a6abf
https://hg.mozilla.org/mozilla-central/rev/4ddd36462bdf
https://hg.mozilla.org/mozilla-central/rev/8f6416404aea
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.