Remove dead mozilla_sampler_* functions

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mstange, Assigned: njn)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

2 years ago
It's unused.
(Assignee)

Comment 1

2 years ago
Posted patch Remove mozilla_sampler_save (obsolete) — Splinter Review
It's unused.
Attachment #8827720 - Flags: review?(mstange)
(Assignee)

Updated

2 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Actually, more than just mozilla_sampler_save() can be removed...
Summary: Remove mozilla_sampler_save → Remove dead mozilla_sampler_* functions
(Assignee)

Comment 3

2 years ago
It's unused.
Attachment #8827742 - Flags: review?(mstange)
(Assignee)

Updated

2 years ago
Attachment #8827720 - Attachment is obsolete: true
Attachment #8827720 - Flags: review?(mstange)
(Assignee)

Comment 5

2 years ago
This also allows the removal of GeckoSampler::ToFileAsync() and one overloading
of ProfileGatherer::Start().
Attachment #8827749 - Flags: review?(mstange)
(Reporter)

Updated

2 years ago
Attachment #8827742 - Flags: review?(mstange) → review+
(Reporter)

Updated

2 years ago
Attachment #8827743 - Flags: review?(mstange) → review+
(Reporter)

Comment 6

2 years ago
Comment on attachment 8827749 [details] [diff] [review]
(part 3) - Remove mozilla_sampler_save_profile_to_file_async

Review of attachment 8827749 [details] [diff] [review]:
-----------------------------------------------------------------

This is currently intended to be called from the debugger (at least that's how Thinker is using it to get TaskTracer data at the moment). We should also expose it on nsIProfiler so that Talos profiling can use it. Talos currently uses dumpProfileToFile which calls the sync version of this and thus misses subprocess profiles.
Attachment #8827749 - Flags: review?(mstange) → review-

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b7baa1086a60
https://hg.mozilla.org/mozilla-central/rev/c93c8b83e929
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.