Remove dead mozilla_sampler_* functions

RESOLVED FIXED in Firefox 53

Status

()

Core
Gecko Profiler
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: mstange, Assigned: njn)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

8 months ago
It's unused.
(Assignee)

Comment 1

7 months ago
Created attachment 8827720 [details] [diff] [review]
Remove mozilla_sampler_save

It's unused.
Attachment #8827720 - Flags: review?(mstange)
(Assignee)

Updated

7 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 months ago
Actually, more than just mozilla_sampler_save() can be removed...
Summary: Remove mozilla_sampler_save → Remove dead mozilla_sampler_* functions
(Assignee)

Comment 3

7 months ago
Created attachment 8827742 [details] [diff] [review]
(part 1) - Remove mozilla_sampler_save

It's unused.
Attachment #8827742 - Flags: review?(mstange)
(Assignee)

Updated

7 months ago
Attachment #8827720 - Attachment is obsolete: true
Attachment #8827720 - Flags: review?(mstange)
(Assignee)

Comment 4

7 months ago
Created attachment 8827743 [details] [diff] [review]
(part 2) - Remove mozilla_sampler_get_responsiveness declaration

It's unused.
Attachment #8827743 - Flags: review?(mstange)
(Assignee)

Comment 5

7 months ago
Created attachment 8827749 [details] [diff] [review]
(part 3) - Remove mozilla_sampler_save_profile_to_file_async

This also allows the removal of GeckoSampler::ToFileAsync() and one overloading
of ProfileGatherer::Start().
Attachment #8827749 - Flags: review?(mstange)
(Reporter)

Updated

7 months ago
Attachment #8827742 - Flags: review?(mstange) → review+
(Reporter)

Updated

7 months ago
Attachment #8827743 - Flags: review?(mstange) → review+
(Reporter)

Comment 6

7 months ago
Comment on attachment 8827749 [details] [diff] [review]
(part 3) - Remove mozilla_sampler_save_profile_to_file_async

Review of attachment 8827749 [details] [diff] [review]:
-----------------------------------------------------------------

This is currently intended to be called from the debugger (at least that's how Thinker is using it to get TaskTracer data at the moment). We should also expose it on nsIProfiler so that Talos profiling can use it. Talos currently uses dumpProfileToFile which calls the sync version of this and thus misses subprocess profiles.
Attachment #8827749 - Flags: review?(mstange) → review-
(Assignee)

Comment 7

7 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7baa1086a601d3e7a11e2ea7f853ce55529429f
Bug 1328373 (part 1) - Remove mozilla_sampler_save. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c93c8b83e929b1752bb8b886de2d8d30f307842a
Bug 1328373 (part 2) - Remove mozilla_sampler_get_responsiveness declaration. r=mstange.

Comment 8

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b7baa1086a60
https://hg.mozilla.org/mozilla-central/rev/c93c8b83e929
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.