1328373 - Remove dead mozilla_sampler_* functions

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Markus Stange [:mstange]]

It's unused.

Comment 1

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Remove mozilla_sampler_save

It's unused.

Comment 2

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Actually, more than just mozilla_sampler_save() can be removed...

Comment 3

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: (part 1) - Remove mozilla_sampler_save

It's unused.

Comment 4

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: (part 2) - Remove mozilla_sampler_get_responsiveness declaration

It's unused.

Comment 5

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: (part 3) - Remove mozilla_sampler_save_profile_to_file_async

This also allows the removal of GeckoSampler::ToFileAsync() and one overloading
of ProfileGatherer::Start().

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8827749 [details] [diff] [review]
(part 3) - Remove mozilla_sampler_save_profile_to_file_async

Review of attachment 8827749 [details] [diff] [review]:
-----------------------------------------------------------------

This is currently intended to be called from the debugger (at least that's how Thinker is using it to get TaskTracer data at the moment). We should also expose it on nsIProfiler so that Talos profiling can use it. Talos currently uses dumpProfileToFile which calls the sync version of this and thus misses subprocess profiles.

Comment 7

[Nicholas Nethercote [:njn] (On Long Service Leave)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7baa1086a601d3e7a11e2ea7f853ce55529429f
Bug 1328373 (part 1) - Remove mozilla_sampler_save. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c93c8b83e929b1752bb8b886de2d8d30f307842a
Bug 1328373 (part 2) - Remove mozilla_sampler_get_responsiveness declaration. r=mstange.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7baa1086a60
https://hg.mozilla.org/mozilla-central/rev/c93c8b83e929