Closed Bug 1328498 Opened 5 years ago Closed 5 years ago

Sourceeditor appendTo HTML element supports

Categories

(DevTools :: Source Editor, defect, P1)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Iteration:
53.4 - Jan 9
Tracking Status
firefox53 --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

appendTo() method always append XUL iframe no matter parent element is XUL or HTML. We should support this by detecting parent namespaceURI to create correct namespace iframe accordingly.
Here is a small patch for addressing the issue which came across in bug 1317650.
Iteration: --- → 53.4 - Jan 9
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor][triage] → [netmonitor]
Comment on attachment 8823507 [details]
Bug 1328498 - Sourceeditor appendTo HTML element supports

https://reviewboard.mozilla.org/r/102038/#review102560

R+

Honza
Attachment #8823507 - Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b27f68f4dbd6
Sourceeditor appendTo HTML element supports r=Honza
https://hg.mozilla.org/mozilla-central/rev/b27f68f4dbd6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.