Closed
Bug 1328530
Opened 8 years ago
Closed 8 years ago
Remove useless override of nsDocument::CreateShell as well as doCreateShell
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
There was a 4th parameter on doCreateShell which nsHTMLDocument invokes with a different value than nsDocument. But that parameter was removed in bug 1232852 since it is identified to be an unused parameter. Given that, we can safely remove nsHTMLDocument::CreateShell and merge nsDocument::doCreateShell into nsDocument::CreateShell.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823542 [details] Bug 1328530 - Remove useless nsHTMLDocument::CreateShell and nsDocument::doCreateShell. https://reviewboard.mozilla.org/r/102070/#review102494
Attachment #8823542 -
Flags: review?(bugs) → review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2567348b74b5 Remove useless nsHTMLDocument::CreateShell and nsDocument::doCreateShell. r=smaug
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2567348b74b5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•