Closed Bug 1328540 Opened 3 years ago Closed 3 years ago

Convert NS_STYLE_HYPHENS_* to an enum class

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jeremychen, Assigned: jeremychen)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Just passed by NS_STYLE_HYPHENS_* while investigating Bug 1056516. Let's fix it.
Attachment #8823556 - Flags: review?(xidorn+moz)
Comment on attachment 8823556 [details]
Bug 1328540 - convert NS_STYLE_HYPHENS_* to an enum class.

https://reviewboard.mozilla.org/r/102086/#review102424

r=me with the issue addressed.

::: gfx/thebes/gfxTextRun.h:23
(Diff revision 1)
>  #include "mozilla/MemoryReporting.h"
>  #include "DrawMode.h"
>  #include "harfbuzz/hb.h"
>  #include "nsUnicodeScriptCodes.h"
>  #include "nsColor.h"
> +#include "nsStyleConsts.h"           // for StyleHyphens

I worry about adding this new dependency. Could you instead just adding `enum class StyleHyphens : uint8_t;` in `namespace mozilla` instead of adding this header?
Attachment #8823556 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8823556 [details]
Bug 1328540 - convert NS_STYLE_HYPHENS_* to an enum class.

https://reviewboard.mozilla.org/r/102086/#review102424

> I worry about adding this new dependency. Could you instead just adding `enum class StyleHyphens : uint8_t;` in `namespace mozilla` instead of adding this header?

Sure. No problem. Thanks for the review.
Attachment #8823709 - Flags: review?(jeremychen)
Comment on attachment 8823709 [details]
Bug 1328540 - trim trailing whitespaces.

https://reviewboard.mozilla.org/r/102228/#review102536

Most are comments only. So r=me.
Attachment #8823709 - Flags: review?(jeremychen) → review+
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f04167e265f0
convert NS_STYLE_HYPHENS_* to an enum class. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/6683fa3d827d
trim trailing whitespaces. r=jeremychen
https://hg.mozilla.org/mozilla-central/rev/f04167e265f0
https://hg.mozilla.org/mozilla-central/rev/6683fa3d827d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.