1328540 - Convert NS_STYLE_HYPHENS_* to an enum class

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jeremy Chen ([e-mail])]

Just passed by NS_STYLE_HYPHENS_* while investigating Bug 1056516. Let's fix it.

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Bug 1328540 - convert NS_STYLE_HYPHENS_* to an enum class.

Review commit: https://reviewboard.mozilla.org/r/102086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102086/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8823556 [details]
Bug 1328540 - convert NS_STYLE_HYPHENS_* to an enum class.

https://reviewboard.mozilla.org/r/102086/#review102424

r=me with the issue addressed.

::: gfx/thebes/gfxTextRun.h:23
(Diff revision 1)
>  #include "mozilla/MemoryReporting.h"
>  #include "DrawMode.h"
>  #include "harfbuzz/hb.h"
>  #include "nsUnicodeScriptCodes.h"
>  #include "nsColor.h"
> +#include "nsStyleConsts.h"           // for StyleHyphens

I worry about adding this new dependency. Could you instead just adding `enum class StyleHyphens : uint8_t;` in `namespace mozilla` instead of adding this header?

Comment 3

[Jeremy Chen ([e-mail])]

Comment on attachment 8823556 [details]
Bug 1328540 - convert NS_STYLE_HYPHENS_* to an enum class.

https://reviewboard.mozilla.org/r/102086/#review102424

> I worry about adding this new dependency. Could you instead just adding `enum class StyleHyphens : uint8_t;` in `namespace mozilla` instead of adding this header?

Sure. No problem. Thanks for the review.

Comment 4

[Jeremy Chen ([e-mail])]

Attachment: Bug 1328540 - trim trailing whitespaces.

Trim trailing whitespaces for files that are touched in this bug:

  gfxTextRun.h
  gfxTextRun.cpp
  nsTextFrame.cpp
  nsCSSProps.cpp

Review commit: https://reviewboard.mozilla.org/r/102228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102228/

Comment 5

[Jeremy Chen ([e-mail])]

Comment on attachment 8823556 [details]
Bug 1328540 - convert NS_STYLE_HYPHENS_* to an enum class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102086/diff/1-2/

Comment 6

[Jeremy Chen ([e-mail])]

Comment on attachment 8823709 [details]
Bug 1328540 - trim trailing whitespaces.

https://reviewboard.mozilla.org/r/102228/#review102536

Most are comments only. So r=me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f04167e265f0
convert NS_STYLE_HYPHENS_* to an enum class. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/6683fa3d827d
trim trailing whitespaces. r=jeremychen

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f04167e265f0
https://hg.mozilla.org/mozilla-central/rev/6683fa3d827d