Closed Bug 1328605 Opened 7 years ago Closed 7 years ago

Continue supporting type=content-* to mean type=content for "a bit" to help add-ons migrate

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details 
      No description provided.
Comment on attachment 8823753 [details]
Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,

https://reviewboard.mozilla.org/r/102254/#review103228

r=me, but please fix the backwards check!

::: dom/base/nsFrameLoader.cpp:3372
(Diff revision 1)
>    parentTreeOwner->ContentShellRemoved(mDocShell);
> -  if (aElement->AttrValueIs(kNameSpaceID_None, TypeAttrName(), nsGkAtoms::content, eIgnoreCase)) {
> +
> +  nsAutoString value;
> +  aElement->GetAttr(kNameSpaceID_None, TypeAttrName(), value);
> +
> +  if (!value.LowerCaseEqualsLiteral("content") &&

This boolean is backwards.  It should be:

    if (value.LowerCaseEqualsLiteral("content") ||
        StringBeginsWith(value, NS_LITERAL_STRING("content-"),
                         nsCaseInsensitiveStringComparator()))
Attachment #8823753 - Flags: review?(bzbarsky) → review+
Comment on attachment 8823753 [details]
Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,

https://reviewboard.mozilla.org/r/102254/#review103228

> This boolean is backwards.  It should be:
> 
>     if (value.LowerCaseEqualsLiteral("content") ||
>         StringBeginsWith(value, NS_LITERAL_STRING("content-"),
>                          nsCaseInsensitiveStringComparator()))

How embarrassing! Fixed now. :-\
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/83fbff91e9d2
re-add support for type=content-foo in order to smooth the way for add-ons, r=bz
https://hg.mozilla.org/mozilla-central/rev/83fbff91e9d2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1427302
You need to log in before you can comment on or make changes to this bug.