1328605 - Continue supporting type=content-* to mean type=content for "a bit" to help add-ons migrate

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,

Review commit: https://reviewboard.mozilla.org/r/102254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102254/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8823753 [details]
Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,

https://reviewboard.mozilla.org/r/102254/#review103228

r=me, but please fix the backwards check!

::: dom/base/nsFrameLoader.cpp:3372
(Diff revision 1)
>    parentTreeOwner->ContentShellRemoved(mDocShell);
> -  if (aElement->AttrValueIs(kNameSpaceID_None, TypeAttrName(), nsGkAtoms::content, eIgnoreCase)) {
> +
> +  nsAutoString value;
> +  aElement->GetAttr(kNameSpaceID_None, TypeAttrName(), value);
> +
> +  if (!value.LowerCaseEqualsLiteral("content") &&

This boolean is backwards.  It should be:

    if (value.LowerCaseEqualsLiteral("content") ||
        StringBeginsWith(value, NS_LITERAL_STRING("content-"),
                         nsCaseInsensitiveStringComparator()))

Comment 3

[:Gijs (he/him)]

Comment on attachment 8823753 [details]
Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102254/diff/1-2/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8823753 [details]
Bug 1328605 - re-add support for type=content-foo in order to smooth the way for add-ons,

https://reviewboard.mozilla.org/r/102254/#review103228

> This boolean is backwards.  It should be:
> 
>     if (value.LowerCaseEqualsLiteral("content") ||
>         StringBeginsWith(value, NS_LITERAL_STRING("content-"),
>                          nsCaseInsensitiveStringComparator()))

How embarrassing! Fixed now. :-\

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83fbff91e9d2
re-add support for type=content-foo in order to smooth the way for add-ons, r=bz

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83fbff91e9d2