1328675 - Simple problem unwrapping AES sym keys on token

Status: RESOLVED FIXED

(JSS Graveyard :: Library, defect)

Description

[jmagne]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161114215916

Steps to reproduce:

I wrote some code that tries to unwrap an aes sym key on the token like this:

 aes128 = keyWrap.unwrapSymmetric(wrappedKey, SymmetricKey.AES, 16);




Actual results:

When later getting the algorithm like this:

String alg = aes128.getAlgorithm();

It was returning RCS which is incorrect. 
The cause seems to be a simple switch statement that doesn't handle AES. This will be evident in the very simple patch to follow.


Expected results:

It should give us the AES type key.

Comment 1

[jmagne]

Very simple patch to address this:
diff -up ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java.aes ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java
--- ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java.aes	2017-01-03 17:14:57.642278989 -0800
+++ ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java	2017-01-03 17:44:03.220626460 -0800
@@ -617,7 +617,9 @@ final class PK11KeyWrapper implements Ke
             return EncryptionAlgorithm.DES3_ECB;
         } else if( type == SymmetricKey.RC4 ) {
             return EncryptionAlgorithm.RC4;
-        } else {
+        } else if( type == SymmetricKey.AES ) {
+            return EncryptionAlgorithm.AES_128_ECB;
+        } else  {
             Assert._assert( type == SymmetricKey.RC2 );
             return EncryptionAlgorithm.RC2_CBC;
         }

Comment 2

[jmagne]

Attachment: Simple patch with fix.

Comment 3

[Matthew Harmsen]

Comment on attachment 8844694 [details] [diff] [review]
Simple patch with fix.

ACK -- this patch should be applied as Patch #34 upstream:

* jss-unwrap-AES-sym-keys-on-token.patch

Comment 4

[Elio Maldonado]

Pushed: https://hg.mozilla.org/projects/jss/rev/62b912cd573bdb08c391a3082538c3ae76da1b9a

Comment 5

[Elio Maldonado]

Historical Note:
Patch34:        jss-unwrap-AES-sym-keys-on-token.patch