1328676 - Web content frame not in focus after creating Marionette session

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The web content frame (currently selected <xul:browser>) is not in focus after creating a new Marionette session.  This causes issues such as https://github.com/mozilla/geckodriver/issues/394.

It seems that the root cause is that we somehow focus the address bar after opening the first window. To ensure proper focus is given to the web content frame (the `<xul:browser>` element), we ought to focus this after creating a session and upon navigation.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1328676 - Document some particulars of browser.Context;

browser.Context has an awful API and this is a small step in the direction
of mitigating some common misconceptions about its internal state.

Review commit: https://reviewboard.mozilla.org/r/102294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102294/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1328676 - Focus web content on starting new session and navigating;

When a new Marionette session is started, the web content frame (currently
selected <xul:browser> element) is not in focus, causing issues such
as https://github.com/mozilla/geckodriver/issues/394.

This changes the current web content to be selected upon top-level
browsing context navigation and the creation of new sessions.

Review commit: https://reviewboard.mozilla.org/r/102296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102296/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8823776 [details]
Bug 1328676 - Document some particulars of browser.Context;

https://reviewboard.mozilla.org/r/102294/#review102892

Comment 4

[David Burns :automatedtester]

Comment on attachment 8823777 [details]
Bug 1328676 - Focus web content on starting new session and navigating;

https://reviewboard.mozilla.org/r/102296/#review102894

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7410544dfba4
Document some particulars of browser.Context; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/8c25f4454f5b
Focus web content on starting new session and navigating; r=automatedtester

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7410544dfba4
https://hg.mozilla.org/mozilla-central/rev/8c25f4454f5b

Comment 7

[Andreas Tolfsen ❲:ato❳]

Sheriffs: Please uplift this to Aurora as test-only.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ab4717c0d745
https://hg.mozilla.org/releases/mozilla-aurora/rev/274babf768bc