The default bug view has changed. See this FAQ.

Firefox device permission dialog box is not accessible via keyboard

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Site Identity and Permission Panels
P3
normal
VERIFIED FIXED
3 months ago
a month ago

People

(Reporter: rdaware, Assigned: johannh)

Tracking

({access})

unspecified
Firefox 53
access
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52- verified, firefox53 verified, firefox54 verified, firefox-esr52 fixed)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 months ago
Created attachment 8823863 [details]
Screen Shot 2017-01-04 at 3.25.23 PM.png

Try getting a Firefox device permission box for microphone or camera. 

Expected Result:
The device permission box is accessible by keyboard controls(Tab,Arrows, Enter)

Actual Result:
The device permission box can be accessed by mouse only.
(Assignee)

Updated

3 months ago
Component: Device Permissions → Site Identity and Permission Panels
Whiteboard: [fxprivacy] [triage]

Updated

3 months ago
Priority: -- → P3
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Keywords: access
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 months ago
This patch makes focusing an anchor icon and pressing space or enter focus the panel. I hope that's sufficient.
(Assignee)

Comment 3

2 months ago
Note that by switching panels it was already possible to focus the panel that was switched to, but that wasn't a great situation :)
(Assignee)

Updated

2 months ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED

Comment 4

2 months ago
mozreview-review
Comment on attachment 8828136 [details]
Bug 1328740 - Focus popup notification panels on anchor icon keypress.

https://reviewboard.mozilla.org/r/105638/#review106772

I'm not sure focusing the main button rather than the first focusable element in the panel is perfect, but this is already a very nice improvement, so r+ anyway. Thanks for looking into this! :-)
Attachment #8828136 - Flags: review?(florian) → review+

Comment 5

2 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41914acaabea
Focus popup notification panels on anchor icon keypress. r=florian
(Reporter)

Comment 6

2 months ago
Hi Johann,

which version can we expect this change to be in?
Flags: needinfo?(jhofmann)
(Assignee)

Comment 7

2 months ago
Hey, once this gets merged into central it will be in 53. That will be Aurora/Developer Edition in a few days.
Flags: needinfo?(jhofmann)

Comment 8

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/41914acaabea
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 9

2 months ago
Build ID: 20170131030205
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

Verified as fixed on on Windows 10 x 64, Mac OS X 10.10 and Ubuntu 16.04 x64 on Firefox Nightly 54.0a1.

On Mac OS X 10.11 and Mac OS X 10.12 permission dialog box is not accessible using keyboard. I logged this issue 1335737.

I logged another two issue regarding the device permission box accessibility using keyboard 1335741 and 1335765.
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
status-firefox54: --- → verified
Duplicate of this bug: 1282938
[Tracking Requested - why for this release]: permission prompts should be keyboard accessible.

Per discussion in bug 1282938 and on IRC in #privacy, it seems like we want to uplift this fix to 52 so that it's in the next ESR.
status-firefox52: --- → affected
tracking-firefox52: --- → ?
Flags: needinfo?(jhofmann)
(Assignee)

Comment 12

a month ago
Comment on attachment 8828136 [details]
Bug 1328740 - Focus popup notification panels on anchor icon keypress.

Approval Request Comment
[Feature/Bug causing the regression]: Long ago, this is relevant for 52 because we'd like to fix this a11y issue in ESR
[User impact if declined]: Permission requests are not keyboard accessible which makes web permissions basically a11y-broken
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Show a web permission e.g. on https://permission.site. Focus the urlbar, press Shift + tab. Press space. The permission doorhanger should have focus.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small frontend change that focuses the popup on keypress.
[String changes made/needed]: None
Flags: needinfo?(jhofmann)
Attachment #8828136 - Flags: approval-mozilla-beta?
Attachment #8828136 - Flags: approval-mozilla-aurora?
Comment on attachment 8828136 [details]
Bug 1328740 - Focus popup notification panels on anchor icon keypress.

It's been in FF53 already. Aurora53-.
Attachment #8828136 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
(Assignee)

Comment 14

a month ago
(In reply to Gerry Chang [:gchang] from comment #13)
> Comment on attachment 8828136 [details]
> Bug 1328740 - Focus popup notification panels on anchor icon keypress.
> 
> It's been in FF53 already. Aurora53-.

Right, sorry, my muscle memory selected both. :)
Comment on attachment 8828136 [details]
Bug 1328740 - Focus popup notification panels on anchor icon keypress.

a11y fix for permission popups, should be in 52.0b7
Attachment #8828136 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Updated

a month ago
Depends on: 1340112

Comment 16

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/1eb3b2fe8c26
status-firefox52: affected → fixed
Flagging this for verification, instructions in Comment 12.
Flags: qe-verify+

Comment 18

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-esr52/rev/1eb3b2fe8c26
status-firefox-esr52: --- → fixed
Flags: in-testsuite+
tracking-firefox52: ? → -
Reproduced the initial issue using old Nightly from 2017-01-04 under Ubuntu 16.04 32bit, verified that this is no longer reproducible using Firefox 52 beta 8 under Windows 10 64bit and Ubuntu 16.04 32bit.
status-firefox52: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.