Last Comment Bug 1328798 - Enable the no-delete-var rule for eslint
: Enable the no-delete-var rule for eslint
Status: RESOLVED FIXED
:
Product: Toolkit
Classification: Components
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal (vote)
: mozilla53
Assigned To: Jared Wein [:jaws] (please needinfo? me)
:
:
Mentors:
Depends on:
Blocks: 1207619
  Show dependency treegraph
 
Reported: 2017-01-04 21:11 PST by Jared Wein [:jaws] (please needinfo? me)
Modified: 2017-01-05 17:29 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
fixed

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. (59 bytes, text/x-review-board-request)
2017-01-04 21:14 PST, Jared Wein [:jaws] (please needinfo? me)
jkt: review+
Details | Review

Description User image Jared Wein [:jaws] (please needinfo? me) 2017-01-04 21:11:53 PST
There is only one error reported with this rule enabled and it appears to be a bug.

In /browser/base/content/browser.js,
  6667:5   error  Variables should not be deleted.                                        no-delete-var (eslint)
Comment 1 User image Jared Wein [:jaws] (please needinfo? me) 2017-01-04 21:14:45 PST Comment hidden (mozreview-request)
Comment 2 User image Jonathan Kingston [:jkt] 2017-01-05 08:18:52 PST
Comment on attachment 8823946 [details]
Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule.

https://reviewboard.mozilla.org/r/102422/#review102972

LGTM thanks
Comment 3 User image Pulsebot 2017-01-05 08:59:25 PST
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b33b0cfdf138
Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt
Comment 4 User image Iris Hsiao [:ihsiao] 2017-01-05 10:12:38 PST
sorry had to backout this for functional tests failures, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=66472984&repo=autoland&lineNumber=37775
Comment 5 User image Pulsebot 2017-01-05 10:19:18 PST
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba2374f2a6ff
Backed out changeset b33b0cfdf138 for functional test bustages
Comment 6 User image Jared Wein [:jaws] (please needinfo? me) 2017-01-05 10:23:19 PST Comment hidden (mozreview-request)
Comment 7 User image Pulsebot 2017-01-05 10:24:24 PST
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5eb6aea7a1c
Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt
Comment 8 User image Wes Kocher (:KWierso) 2017-01-05 17:29:48 PST
https://hg.mozilla.org/mozilla-central/rev/f5eb6aea7a1c

Note You need to log in before you can comment on or make changes to this bug.