The default bug view has changed. See this FAQ.

Enable the no-delete-var rule for eslint

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There is only one error reported with this rule enabled and it appears to be a bug.

In /browser/base/content/browser.js,
  6667:5   error  Variables should not be deleted.                                        no-delete-var (eslint)
(Assignee)

Updated

3 months ago
Blocks: 1207619
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8823946 [details]
Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule.

https://reviewboard.mozilla.org/r/102422/#review102972

LGTM thanks
Attachment #8823946 - Flags: review?(jkt) → review+

Comment 3

3 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b33b0cfdf138
Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt

Comment 4

3 months ago
sorry had to backout this for functional tests failures, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=66472984&repo=autoland&lineNumber=37775
Flags: needinfo?(jaws)

Comment 5

3 months ago
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba2374f2a6ff
Backed out changeset b33b0cfdf138 for functional test bustages
Comment hidden (mozreview-request)

Comment 7

3 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5eb6aea7a1c
Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt
(Assignee)

Updated

3 months ago
Flags: needinfo?(jaws)

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f5eb6aea7a1c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.