1328798 - Enable the no-delete-var rule for eslint

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

There is only one error reported with this rule enabled and it appears to be a bug.

In /browser/base/content/browser.js,
  6667:5   error  Variables should not be deleted.                                        no-delete-var (eslint)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule.

Review commit: https://reviewboard.mozilla.org/r/102422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102422/

Comment 2

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8823946 [details]
Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule.

https://reviewboard.mozilla.org/r/102422/#review102972

LGTM thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b33b0cfdf138
Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt

Comment 4

[Iris Hsiao [:ihsiao]]

sorry had to backout this for functional tests failures, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=66472984&repo=autoland&lineNumber=37775

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba2374f2a6ff
Backed out changeset b33b0cfdf138 for functional test bustages

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8823946 [details]
Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102422/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5eb6aea7a1c
Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f5eb6aea7a1c