Closed
Bug 1328798
Opened 7 years ago
Closed 7 years ago
Enable the no-delete-var rule for eslint
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
There is only one error reported with this rule enabled and it appears to be a bug. In /browser/base/content/browser.js, 6667:5 error Variables should not be deleted. no-delete-var (eslint)
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823946 [details] Bug 1328798 - Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. https://reviewboard.mozilla.org/r/102422/#review102972 LGTM thanks
Attachment #8823946 -
Flags: review?(jkt) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b33b0cfdf138 Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt
|
||
Comment 4•7 years ago
|
||
sorry had to backout this for functional tests failures, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=66472984&repo=autoland&lineNumber=37775
Flags: needinfo?(jaws)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba2374f2a6ff Backed out changeset b33b0cfdf138 for functional test bustages
| Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5eb6aea7a1c Enable the no-delete-var rule for eslint and fix the one error spotted by the rule. r=jkt
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(jaws)
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5eb6aea7a1c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•