The default bug view has changed. See this FAQ.

Enable the no-unsafe-finally rule for eslint

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There are four errors with this rule enabled. Three of them seem innocuous but one of them appears to be a legitimate bug because an exception that is caught is rethrown in the catch block, but the finally block returns true thus preventing the exception from being rethrown.

c:\fx\browser\base\content\browser-gestureSupport.js
  1154:7   error  Unsafe usage of ReturnStatement.                  no-unsafe-finally (eslint)

c:\fx\toolkit\components\telemetry\TelemetryStorage.jsm
1524:13  error  Unsafe usage of ContinueStatement.              no-unsafe-finally (eslint)

c:\fx\toolkit\modules\WindowsRegistry.jsm
  87:7   error  Unsafe usage of ReturnStatement.               no-unsafe-finally (eslint)

c:\fx\toolkit\mozapps\extensions\internal\GMPProvider.jsm
  315:9   error  Unsafe usage of ReturnStatement.            no-unsafe-finally (eslint)
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8823951 [details]
Bug 1328802 - Enable the no-unsafe-finally rule for eslint and fix the four errors that are triggered by it by moving the control flow statement outside of the finally block.

https://reviewboard.mozilla.org/r/102430/#review102980
Attachment #8823951 - Flags: review?(dtownsend) → review+

Comment 3

3 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d43f110b88c
Enable the no-unsafe-finally rule for eslint and fix the four errors that are triggered by it by moving the control flow statement outside of the finally block. r=mossop

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3d43f110b88c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.