1328802 - Enable the no-unsafe-finally rule for eslint

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

There are four errors with this rule enabled. Three of them seem innocuous but one of them appears to be a legitimate bug because an exception that is caught is rethrown in the catch block, but the finally block returns true thus preventing the exception from being rethrown.

c:\fx\browser\base\content\browser-gestureSupport.js
  1154:7   error  Unsafe usage of ReturnStatement.                  no-unsafe-finally (eslint)

c:\fx\toolkit\components\telemetry\TelemetryStorage.jsm
1524:13  error  Unsafe usage of ContinueStatement.              no-unsafe-finally (eslint)

c:\fx\toolkit\modules\WindowsRegistry.jsm
  87:7   error  Unsafe usage of ReturnStatement.               no-unsafe-finally (eslint)

c:\fx\toolkit\mozapps\extensions\internal\GMPProvider.jsm
  315:9   error  Unsafe usage of ReturnStatement.            no-unsafe-finally (eslint)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1328802 - Enable the no-unsafe-finally rule for eslint and fix the four errors that are triggered by it by moving the control flow statement outside of the finally block.

Review commit: https://reviewboard.mozilla.org/r/102430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102430/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8823951 [details]
Bug 1328802 - Enable the no-unsafe-finally rule for eslint and fix the four errors that are triggered by it by moving the control flow statement outside of the finally block.

https://reviewboard.mozilla.org/r/102430/#review102980

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d43f110b88c
Enable the no-unsafe-finally rule for eslint and fix the four errors that are triggered by it by moving the control flow statement outside of the finally block. r=mossop

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3d43f110b88c