132896 - offline: remove ui for ask me at startup & remember prev mode

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[grylchan]

This bug was created first in bugscape 12753 but since
this feature is available in both commercial and mozilla builds,
Scott suggested it be placed in bugzilla.

Adding Michael's comments (original bug description):
>Discused bug 82487 in Mail News bug mtg with Engineering QA Mktng PjM.  Decided
>to minus that bug-and enter this one to remove the UI which does not work.  I
>made this bug as like 82487 as possible, but didn't have the options when
>entering the bug to make it exactly like 82487.\

This is located at Edit|Preferences|offline&diskpace.

Adding RobinF's comments:
>Just to be clear, can someone verify what the UI is that's being removed? Is it 
>the following?
>Preferences>Offline & Disk Space Panel:
>When starting Netscape:
>* Ask me if I want online or offline mode
>* Use my previous online/offline state

And as Far as I know, Robin is correct.

I will close out bugscape 12753.

Comment 1

[Sean Su]

accepting

Comment 2

[Michael Buckland]

Discussed in Mail News bug meeting.  Decided to ADT2 this bug.

Comment 3

[scottputterman]

reassigning to shliang.  If it turns out to be as easy to make the prefs work as
it is to remove the UI then go for it, otherwise let's just remove the UI.

Comment 4

[grylchan]

adding my 1 cent here, judging by alecf's comment in the original
bug: http://bugzilla.mozilla.org/show_bug.cgi?id=82487#c64

> - this is not a front-end issue at ALL except for the actual dialog itself...
>not to mention that this is not mail-specific in the slightest - this is a
>combination of XPApps and Networking. Updating the components to reflect this

I think originally they were trying to fix ui/prefs? Not sure as there
are ton's of comments in the original bug.

But if it turns out to be a prefs bug, cool.

Just wanted to make Shuehan aware of this..

Comment 5

[shliang]

Attachment: patch for removing ui

thanks for the info gary :)

i took a look at the other bug and after reading those comments and looking
around for a bit i've decided to just remove the ui. making the prefs work gets
pretty involved - see comments 64 and 72 in 82487

Comment 6

[Sean Su]

Comment on attachment 77705 [details] [diff] [review]
patch for removing ui

r=ssu for the patch to pref-offline.xul.

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 77705 [details] [diff] [review]
patch for removing ui

I'd suggest leaving the prefs alone (what's
"application.use_ns_plugin_finder"?)

and instead of removing the UI, and adding it back on day, let's just comment
it out with a xul comment saying uncomment once bug #82487 is fixed.

Comment 8

[shliang]

Attachment: commenting out instead

Comment 9

[shliang]

Attachment: woops, last one

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 77910 [details] [diff] [review]
woops, last one

sr=sspitzer, thanks shuehan.

Comment 11

[Lori Kaplan]

a=UI

waiting for drivers approval. Otherwise ready to go. 

Comment 12

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to 1.0. Changing to ADT3.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 77910 [details] [diff] [review]
woops, last one

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 14

[shliang]

checked into trunk and branch

Comment 15

[grylchan]

verified on commercial trunk:
2002041603 Win NT 4.0
2002041603 Mac 10.1.3, Mac 9.2.2
2002041607 linux 2.2

UI is removed and the other UI for offline and diskspace
still work.

Comment 16

[grylchan]

Using commercial branch:
2002-04-19-08-1.0.0/ nt
2002-04-19-05-1.0.0/ mac 10.1.3, mac 9.2.2
2002-04-19-09-1.0.0 linux 2.2


verified UI is removed.

marking as verified.
replacing fixed1.0.0 with verified 1.0.0 in keyword