Closed
Bug 1329016
Opened 9 years ago
Closed 9 years ago
CacheIR: Allow -0 (negative zero) index
Categories
(Core :: JavaScript Engine: JIT, defect, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: evilpies, Assigned: evilpies)
References
(Blocks 2 open bugs)
Details
(Keywords: perf)
Attachments
(1 file)
|
2.14 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Google Docs has IC misses caused by -0. We can truncate those to 0, because ToString(-0) is "0". (Btw we can't do this for strings like "-0", integer exotic objects should even return undefined for this)
We have to communicate this clearly, because if we try to use guardIsInt32 outside of array accesses this is not a valid transformation!
|
||
Updated•9 years ago
|
Blocks: sm-js-perf
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → evilpies
|
|
Assignee | |
Comment 1•9 years ago
|
||
As you said, fixing bug 1330793 made this trivial.
Attachment #8828387 -
Flags: review?(jdemooij)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8828387 [details] [diff] [review]
Allow negative zero in CacheIR index check
Review of attachment 8828387 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8828387 -
Flags: review?(jdemooij) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59962d7c3d8c
Allow negative zero in CacheIR index check. r=jandem
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•