CacheIR: Allow -0 (negative zero) index

RESOLVED FIXED in Firefox 53

Status

()

Core
JavaScript Engine: JIT
P3
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks: 2 bugs, {perf})

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Google Docs has IC misses caused by -0. We can truncate those to 0, because ToString(-0) is "0". (Btw we can't do this for strings like "-0", integer exotic objects should even return undefined for this)

We have to communicate this clearly, because if we try to use guardIsInt32 outside of array accesses this is not a valid transformation!
Keywords: perf
Priority: -- → P3
Blocks: 1307062
Assignee: nobody → evilpies
Created attachment 8828387 [details] [diff] [review]
Allow negative zero in CacheIR index check

As you said, fixing bug 1330793 made this trivial.
Attachment #8828387 - Flags: review?(jdemooij)
Comment on attachment 8828387 [details] [diff] [review]
Allow negative zero in CacheIR index check

Review of attachment 8828387 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8828387 - Flags: review?(jdemooij) → review+

Comment 3

7 months ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59962d7c3d8c
Allow negative zero in CacheIR index check. r=jandem

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/59962d7c3d8c
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.