Closed Bug 1329155 Opened 7 years ago Closed 7 years ago

Custom tabs: Collect information on number of launches (Load_URL) using custom tabs

Categories

(Firefox for Android Graveyard :: Metrics, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jcheng, Assigned: cnevinchen)

References

Details

Attachments

(1 file, 1 obsolete file)

As Mozilla, we want to understand custom tabs usage
Assignee: nobody → cnevinchen
Since the code is almost the same, I've done it in bug 1329157.
Flags: needinfo?(jcheng)
Comment on attachment 8840757 [details]
Bug 1329155 - Send telemetry when custom tab is used.  data-r?bsmedberg

I'll cancel the review flag for now. If we decide to just simply track the invocation number of Custom Tab, maybe we can even do it in CustomTabsActivity and track the customization while tracking the invocation count.
Attachment #8840757 - Flags: review?(liuche)
cool thanks. let's follow up on bug 1329157
Flags: needinfo?(jcheng)
Comment on attachment 8840757 [details]
Bug 1329155 - Send telemetry when custom tab is used.  data-r?bsmedberg

Since bug 1329157 will focus on URL collection, this bug will focus on custom tab usage.
Attachment #8840757 - Flags: review?(s.kaspari)
Attachment #8840757 - Flags: review?(benjamin)
Comment on attachment 8840757 [details]
Bug 1329155 - Send telemetry when custom tab is used.  data-r?bsmedberg

https://reviewboard.mozilla.org/r/115188/#review121146

Data review happens on the documentations. Please update uitelemetry.rst with detailed event docs and re-request review.
Attachment #8840757 - Flags: review?(benjamin) → review-
Comment on attachment 8846226 [details]
Bug 1329155 - Add documentation for the extras used by custom tab usage count.

https://reviewboard.mozilla.org/r/119324/#review122090

::: mobile/android/docs/uitelemetry.rst:314
(Diff revision 1)
>  ``settings.1``
>    Settings activity is active.
> +
> +Extras
> +--------
> +``customtab-load``

As with the other events, please use ".1" so that you can change it in the future.

data-r=me -- please fold this patch with the previous one so that they land together. It's the code reviewer's responsibility to make sure that the code actually matches this documentation.
Attachment #8846226 - Flags: review?(benjamin) → review+
Attachment #8846226 - Attachment is obsolete: true
Comment on attachment 8840757 [details]
Bug 1329155 - Send telemetry when custom tab is used.  data-r?bsmedberg

How do I tag for data-review? Should I just add data-r?bsmedberg or should I also append it after r?sebstian,bsmedberg? Thank you!
Flags: needinfo?(benjamin)
Attachment #8840757 - Flags: review?(benjamin)
In reviewboard you can just add me as another reviewer. Or use the review? or feedback? flag in bugzilla.

I don't need to review this again since I already marked data-review.
Flags: needinfo?(benjamin)
Attachment #8840757 - Flags: review?(benjamin)
Component: General → Metrics
Comment on attachment 8840757 [details]
Bug 1329155 - Send telemetry when custom tab is used.  data-r?bsmedberg

https://reviewboard.mozilla.org/r/115188/#review123400

There seems to be some confusion here: This is not a new event. This is an existing event (load.1) with a different "extra". Therefore you:
* do not need to add that to uitelemetry.rst (load.1 is already in there)
* do not need the ".1" suffix. only events need that.
Attachment #8840757 - Flags: review?(s.kaspari)
Hi Sebastian. 
Thanks for letting me know. That's also my first understanding so I didn't update the .rst. 
Please help me with below questions( I also have question for bug 1329160):

1. If I only use extra, do I need data review ?
2. If I only use extra, do I need to update the document ? Which document should I update?
3. For a requirement like this bug, should add just use extra or I need to add an event / method?

Thanks!
Flags: needinfo?(s.kaspari)
Comment on attachment 8840757 [details]
Bug 1329155 - Send telemetry when custom tab is used.  data-r?bsmedberg

https://reviewboard.mozilla.org/r/115188/#review124346
Attachment #8840757 - Flags: review?(s.kaspari) → review+
We just talked on Vidyo. But to summarize:

> 1. If I only use extra, do I need data review ?

In this case we are not adding a new event. We are adding the already existing "LOAD URL" event to a new entry point. And adding a new extra to mark this new entry point. Historically we have landed such things without an additional review.

Although I just saw that we have a wiki page describing this:
https://wiki.mozilla.org/Firefox/Data_Collection

> 2. If I only use extra, do I need to update the document ? Which document
> should I update?

We haven't documented extras so far. They are a free form string/JSON and therefore a lot of different variations exist. However we have a document describing them for Activity Stream because they are a more complex JSON:
https://gecko.readthedocs.io/en/latest/mobile/android/fennec/activitystreamtelemetry.html

Listing extras on its own doesn't make much sense because they are heavily tied to the event. So if we really want to document them then as part of describing the LOAD URL event. Or like activity stream we could add a document describing the telemetry for custom tabs.

> 3. For a requirement like this bug, should add just use extra or I need to
> add an event / method?

In this case an extra is definitely the right way to go. We want to compare this to other LOAD URL situations.
Flags: needinfo?(s.kaspari)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 12b5be3f7721 -d 89f32ce6bbe4: rebasing 383151:12b5be3f7721 "Bug 1329155 - Send telemetry when custom tab is used. r=sebastian data-r?bsmedberg" (tip)
merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68888b0a32fe
Send telemetry when custom tab is used. r=sebastian data-r?bsmedberg
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/68888b0a32fe
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: