Closed
Bug 1329191
Opened 7 years ago
Closed 7 years ago
Download clang-format 4.0 from tooltool and add a checksum check
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(2 files)
First, as suggested by gps, I would prefer to use tooltool than my personal mozilla http page to store binaries. Second, I would like to add a sha check.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
Have we considered just including the clang-format-diff script in mozilla-central instead of downloading it separately? That way it would have a stable path and could be used by other tools.
|
Assignee | |
Comment 4•7 years ago
|
||
As we have to upload the binaries anyway, not sure we want to do that to avoid sync issues between different version. At least, with the current solution, we are (almost) sure that the script matches the binary. Do you know other tools which use it? (or could)?
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8824422 [details] Bug 1329191 - Download clang-format 4.0 from tooltool and add a checksum check https://reviewboard.mozilla.org/r/102930/#review104032
Attachment #8824422 -
Flags: review?(gps) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8824423 [details] Bug 1329191 - Download clang-format 4.0 from tooltool and add a checksum check. Flake8 on the rest of the file https://reviewboard.mozilla.org/r/102932/#review104034 Thank you for cleaning up the code.
Attachment #8824423 -
Flags: review?(gps) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c2947db3419 Download clang-format 4.0 from tooltool and add a checksum check r=gps https://hg.mozilla.org/integration/autoland/rev/a115a788ded6 Download clang-format 4.0 from tooltool and add a checksum check. Flake8 on the rest of the file r=gps
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c2947db3419 https://hg.mozilla.org/mozilla-central/rev/a115a788ded6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•