1329248 - Enable 26 more ESLint rules for PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

The rules include a mixture of style enforcing and error catching rules.
We pass all these new rules with just a few changes.

Comment 1

[:Cykesiopka]

Attachment: Bug 1329248 - Enable 26 more ESLint rules for PSM.

The "no-mixed-spaces-and-tabs" rule is also disabled since there's no point
having it enabled when the "no-tabs" rule is also enabled.

Review commit: https://reviewboard.mozilla.org/r/104702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104702/

Comment 2

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8826823 [details]
Bug 1329248 - Enable 26 more ESLint rules for PSM.

https://reviewboard.mozilla.org/r/104702/#review105926

Comment 3

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9413d37068adb90230ff813084c90dd6d4eabca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d9de93bd6ec
Enable 26 more ESLint rules for PSM. r=mgoodwin

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3d9de93bd6ec