132929 - buglist.cgi "long format" button doesn't work

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P1)

Description

[Bradley Baetz (:bbaetz)]

From npm.webtools:

"From: Tony Sweets <[e-mail]>
Newsgroups: netscape.public.mozilla.webtools
Subject: long_list.cgi Problems
Date: Fri, 22 Mar 2002 15:38:50 -0700

Hello All

I have the current Bugzilla (2.15) code from CVS and I'm having a
problem with the "Long Format" report. If I do a query, then hit the
"Long Format" Button after my query results appear, an error occurs.
The error message says "You'd have more luck if you gave me some bug
numbers"

I've looked around the code (I'm not a Perl Programmer! I'm a Java Guy)
and I can't find where $buglist is getting assigned values for this
perticular situation. I've notice that the cookie "BUGLIST" is populated
. So my quick solution was to append $::COOKIE{"BUGLIST"} to the
$buglist array at line 63 in long_list.cgi

This works, but I'm sure if this a valid or if it breaks anything.

--Tony
"

Thats not valid - we need to push $vars->{buglist} to the template so that its
in the form. The actual template already tries to us ethis param, but the cgi
never supplies it.

Patch coming.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 75695 [details] [diff] [review]
patch

r= justdave x2

Comment 3

[Bradley Baetz (:bbaetz)]

Checked in, thanks

Comment 4

[Myk Melez [:myk] [@mykmelez]]

This may be more performant with a map:

$vars->{'buglist'} = join(',', map($_->{id}, @bugs));

Comment 5

[Bradley Baetz (:bbaetz)]

wouldn't that mean scanning through the bug aray again? Although I suspect it
wouldn't make a difference with the number of bugs returned by buglist.cgi.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

>wouldn't that mean scanning through the bug aray again?

Yes, but it would happen in compiled code instead of interpreted code.

Comment 7

[Bradley Baetz (:bbaetz)]

I don't follow that - which part of it would be compiled to byte code vs
interpreted?

However, your way is cleaner, so I'll reopen this and attach a new patch

Comment 8

[Bradley Baetz (:bbaetz)]

Attachment: new patch

I thought of having the template do this, but thats messy, because the footer
and the stuff for each bug aren't in the same template.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 76920 [details] [diff] [review]
new patch

Works. r=myk x 2

Comment 10

[Bradley Baetz (:bbaetz)]

Fixed.